Fix owner name SLURLs in inventory offers

[gwigz]

Resolves #325.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 9b93061f-c6a4-4e0f-a1fd-dd8a6dd379a4

📥 Commits

Reviewing files that changed from the base of the PR and between 2b4e3a9 and d0c565e.

📒 Files selected for processing (1)

• indra/newview/llviewermessage.cpp

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

---

📝 Walkthrough

Summary by CodeRabbit

• Bug Fixes
  • Improved chat-history formatting for inventory and task offers.
  • Prevented duplicate link-suppression markup in task-offer messages.
  • Ensured sender and group names display consistently across offer types.

Walkthrough

The change adds a no_link helper and applies it to inventory and task-offer chat-history formatting. Sender and group names receive no-link markup while owner SLURLs remain clickable. Logging uses the preformatted history string to avoid duplicate markup.

Changes

Chat history formatting

Layer / File(s)	Summary
Centralize offer-name formatting indra/newview/llviewermessage.cpp	Adds no_link and applies it to sender, group, and owner names across object and non-object offers while preserving owner SLURLs.
Use preformatted offer history indra/newview/llviewermessage.cpp	Inventory and task-offer logging uses the existing formatted chat-history string instead of adding another <nolink> wrapper.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to d0c56

This change updates how owner names are displayed in inventory offers to prevent unwanted SLURL parsing while preserving the intended owner links. No actionable merge-blocking risk remains beyond normal checks and review.

Suggested reviewers: akleshchev

Poem

A rabbit checked the chat-log trail
And found one link wrapped twice in veil
A helper tidied every name
While SLURLs kept their clickable flame
Clean offer messages now hop along

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The description identifies issue #325 and includes relevant screenshots, but it does not use the required sections or provide testing details and checklist information.	Add the required Description, Related Issues, Checklist, and Additional Notes sections. Summarize the implementation, document local testing and test results, and complete or explicitly mark each checklist item.
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 4 functions across 1 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly identifies the primary change: fixing owner-name SLURLs in inventory offer messages.
Linked Issues check	✅ Passed	The changes address issue #325 by preventing nolink markup from suppressing agent and group SLURLs in inventory offer messages. The task-offer formatting change also prevents duplicate nolink markup.
Out of Scope Changes check	✅ Passed	The changes are limited to inventory offer and task-offer chat-history formatting. They directly support the linked issue objective and contain no unrelated scope.

• Fix all pre-merge checks with AI

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}