Skip to content

Fix "library" label overlapping in the gesture editor - #370

Merged
RyeMutt merged 1 commit into
AlchemyViewer:developfrom
gwigz:gwigz/gesture-preview-label-overlap
Aug 27, 2026
Merged

Fix "library" label overlapping in the gesture editor#370
RyeMutt merged 1 commit into
AlchemyViewer:developfrom
gwigz:gwigz/gesture-preview-label-overlap

Conversation

@gwigz

@gwigz gwigz commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Resolves #348. Claude's initial attempt didn't bother to match the other label offsets, so I've given it a once over too.

image

@coderabbitai

coderabbitai Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: c8b3c423-7461-4e49-96cb-a8aae0750ff6

📥 Commits

Reviewing files that changed from the base of the PR and between 670727d and 1c22c13.

📒 Files selected for processing (1)
  • indra/newview/skins/default/xui/en/floater_preview_gesture.xml

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Summary by CodeRabbit

  • Style
    • Improved the gesture preview window layout by increasing its height.
    • Expanded the gesture library list and repositioned controls for better spacing.

Walkthrough

The gesture preview floater increases in height. The library list and gesture controls move downward to fit the updated layout.

Changes

Gesture preview layout

Layer / File(s) Summary
Floater dimensions and library list
indra/newview/skins/default/xui/en/floater_preview_gesture.xml
The floater height increases from 475 to 500 pixels. The library list height increases from 60 to 76 pixels.
Gesture control positions
indra/newview/skins/default/xui/en/floater_preview_gesture.xml
The Steps label, options text, animation and sound controls, chat editor, animation trigger group, and key-release checkbox move downward.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 1c22c

This localized layout adjustment only changes gesture editor sizing and label positions; no actionable merge-blocking risk remains beyond normal checks and review.

Poem

A rabbit checked the floater's height

More room now keeps the controls right
The list grew tall, the labels slid
Each gesture field now fits its grid
Hop, hop—the layout is tidied tonight

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description identifies issue #348 and includes a screenshot, but it does not follow the required template or document testing, checklist status, and additional context. Add the required Description, Related Issues, Checklist, and Additional Notes sections. Describe the layout changes and record local testing results and checklist completion.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the primary change: fixing the overlapping Library label in the gesture editor.
Linked Issues check ✅ Passed The XML layout changes address issue #348 by correcting overlapping text in the gesture edit floater and aligning label offsets with related controls.
Out of Scope Changes check ✅ Passed The changes are limited to the gesture preview floater layout and directly support the linked issue about overlapping text. No unrelated changes are present.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

  • Fix all pre-merge checks with AI

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

The list grows from 60 to 76, the floater from 475 to 500 to hold it, and
everything below moves down to match.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@RyeMutt
RyeMutt force-pushed the gwigz/gesture-preview-label-overlap branch from 69bf9f1 to 1c22c13 Compare August 27, 2026 14:07
@RyeMutt
RyeMutt merged commit d0aa36d into AlchemyViewer:develop Aug 27, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Gestures edit floater UI

2 participants