Add show_progress flag and CLI option to control progress bar display#116
Open
mattiasboyer wants to merge 3 commits into
Open
Add show_progress flag and CLI option to control progress bar display#116mattiasboyer wants to merge 3 commits into
mattiasboyer wants to merge 3 commits into
Conversation
|
Please merge that pull request, the progress bar is very annoying in production... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a show_progress parameter to the windows() and macos() functions to enable or disable the progress bar during document conversion.
Additionally, it updates the CLI to support a new --no-progress flag that allows users to disable the progress bar from the command line. This flag maps inversely to the show_progress parameter.
Changes:
Added show_progress argument to windows() and macos() functions to conditionally show the tqdm progress bar.
Added --no-progress flag to CLI to disable progress bar.
Updated CLI to pass show_progress=not args.no_progress to convert().
Motivation:
Allow users to disable progress bar for non-interactive or logging scenarios.
Improve usability and code clarity.
The default behavior remains unchanged with progress bars enabled unless --no-progress is specified