Repository navigation
fix: protect Docker build context and verify isolated local persistence - #90
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Actual Docker verification (not TestClient)
Docker Engine 29.6.2; original Dockerfile, Python 3.11.15, original Alembic/Uvicorn entrypoint. Built dedicated local image, no image push, no real .env, no primary data mounts, no host ports. Three fresh owned volumes, two fictional uploaded documents, one directly inserted Chroma vector canary.
Five successful phases: seed/default-off; same-container restart; container removal/recreation with preserved volumes and temporary Hybrid empty-scope enabled; restore disabled configuration; final guarded-image recheck. Across phases: migration 20260705_0001 head and SQLite integrity, JWT/role/tenant checks, unchanged document metadata/source checksums, vector canary and initial audit IDs persisted. Audit counts 2/4/6/8/10. Ticket/Agent action tables stayed empty.
Disabled Hybrid returned sanitized 503; enabled empty scope returned empty search/no_context without provider calls. This is configuration rollback and component persistence, NOT functional Dense answer fallback or non-empty RAG quality.
Image inspection confirmed runtime data/.env paths absent and public template retained; pip check passed. Final image ID and source hashes recorded. One premature local verify during asynchronous restart exited without result; it was not counted as PASS, and verification ran after restart completion, without reseeding.
Verification / cleanup
Still pending
Original Compose with safe fake-env override and host-loopback access; non-empty running-server RAG/indexing; functional Dense answers; independent semantic-quality acceptance. API/business logic, Dockerfile/Compose, .env, frozen prompts and historical provider records unchanged; v5.3.1 remains offline and default Hybrid switches unchanged.