Remove realtime settings updates endpoint#321
Open
marksmith wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change removes the
Aikido::Zen.config.realtime_settings_updates_endpointand the associated probing machinery, used to probe whether the realtime settings updates endpoint is accessible and use it for polling.This is in preparation for an ongoing simplification of endpoints used by Zen by Aikido and should not be merged until the unified realtime endpoint supports realtime settings updates, otherwise this will not work, even if the feature flag is enabled.
See #285 for more information about realtime software updates.
Summary by Aikido
🔧 Refactors
More info