feat: add multi.myreadingmanga#541
Open
Erizur wants to merge 12 commits into
Open
Conversation
kkantan
requested changes
May 28, 2026
Contributor
|
to fix the "Test PR" workflow failing, you should run |
Incremented from the legacy source instead of using a new versioning. woops! Co-authored-by: kantan <31490942+kkantan@users.noreply.github.com>
kkantan
requested changes
May 29, 2026
Contributor
kkantan
left a comment
kkantan
left a comment
There was a problem hiding this comment.
the source appears to work fine, I just left a couple extra suggestions.
Comment on lines
+46
to
+55
| "all" | "none" | "any" | "" => None, | ||
| "en" | "english" => Some("english"), | ||
| "ja" | "jp" | "japanese" => Some("jp"), | ||
| "zh" | "cn" | "chinese" => Some("chinese"), | ||
| "ko" | "kr" | "korean" => Some("korean"), | ||
| "es" | "spanish" => Some("spanish"), | ||
| "fr" | "french" => Some("french"), | ||
| "de" | "german" => Some("german"), | ||
| "it" | "italian" => Some("italian"), | ||
| "pt" | "portuguese" => Some("portuguese"), |
Contributor
There was a problem hiding this comment.
I don't think you need these extra options to match against, since it should only be the values you provide for the source languages.
I guess it's not really needed here, then? Co-authored-by: kantan <31490942+kkantan@users.noreply.github.com>
I originally went with that approach, but I had the wrong idea from c++ signatures that this would cause symbol errors of such. guess not :p Co-authored-by: kantan <31490942+kkantan@users.noreply.github.com>
I forgot to remove this one, my bad Co-authored-by: kantan <31490942+kkantan@users.noreply.github.com>
Co-authored-by: kantan <31490942+kkantan@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mostly tried to fix the old version from the old sources, but ended up doing something a little different.
This should close #335
Summary
Validation