feat: add en.freewebnovel#540
Merged
Merged
Conversation
…s for manga source - first working build
…ext to return Result for better error handling
…ga listing functionality - WIP
… streamline hot entries parsing logic
… improve pagination logic
… unnecessary headers
…stants for tag checks
…queness checks in parsing functions
…r_text to avoid duplicates
MrGcGamer
changed the title
MrGcGamer
force-pushed
the
feat/en-freewebnovel
branch
from
d9d1162 to
9f086ae
Compare
MrGcGamer
force-pushed
the
feat/en-freewebnovel
branch
from
9f086ae to
f6208f7
Compare
… push_scroller to accept optional title
kkantan
requested changes
May 29, 2026
Contributor
kkantan
left a comment
kkantan
left a comment
There was a problem hiding this comment.
to fix the "Test PR" check, minAppVersion should be set to 0.8 in source.json.
overall looks fine, and appears to work fine on device. I just left a few comments about code styling and organization.
MrGcGamer
force-pushed
the
feat/en-freewebnovel
branch
2 times, most recently
from
bd5224a to
f5a63a8
Compare
MrGcGamer
force-pushed
the
feat/en-freewebnovel
branch
from
f5a63a8 to
88c8579
Compare
kkantan
requested changes
May 30, 2026
Contributor
kkantan
left a comment
kkantan
left a comment
There was a problem hiding this comment.
have you run cargo fmt? there are a few things that look like they're formatted slightly inconsistently. other than that it looks good.
Contributor
Author
I did.. I am also not 100% with how it did things, but that's the result of cargo fmt |
Contributor
|
we can merge this since it looks like the test is only failing due to an aidoku cli bug: Aidoku/aidoku-rs#36. |
kkantan
approved these changes
May 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey there,
This PR adds en.freewebnovel source.
Fair warning:A lot of this is vibe-coded, but I reworked some of the more lackluster code and proofread the code.However, if you do find anything which can be improved upon, do let me know.For now, I will open this as a draft, as I am still working on it, but if you already have stuff to say, I'd love to hear it.Summary:
Alright, after vibecoding the start to get it into a somewhat working state I basically rewrote all of the logic, so the code should be mostly clean now.
NOTE: The icon is AI generated, as the website doesn't seem to have a high enough quality version of their logo available anywhere
This ready for review now