[16.0][IMP] agx_approval: partner/employee smart buttons to approval requests - #1237
Open
n3n wants to merge 1 commit into
Open
[16.0][IMP] agx_approval: partner/employee smart buttons to approval requests#1237n3n wants to merge 1 commit into
n3n wants to merge 1 commit into
Conversation
… requests Add back-link smart buttons on res.partner and hr.employee forms that count and open the approval.request records where the contact/employee appears (participant_ids or owner_id), closing the loop that previously only went from request to person.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
res.partnerforms that counts and opensapproval.requestrecords where the contact appears inparticipant_ids.hr.employeeforms that counts and opensapproval.requestrecords where the employee isowner_idor appears viawork_contact_idinparticipant_ids(deduplicated).sudo()for accurate badges; clicking opens the list/form under the user's own permissions (record rules still apply).Test plan
-u agx_approvaland open a contact/employee that appears in an approval request; confirm the badge count and that clicking opens the filtered list (or single form when count is 1).owner_idand a participant on their own request is not double-counted.agx_approval.group_approval_own(hidden for users without any approval group).