fix(status): stop showing open-PR/draft sessions as "Working" in the status pill#2346
Open
aprv10 wants to merge 2 commits into
Open
fix(status): stop showing open-PR/draft sessions as "Working" in the status pill#2346aprv10 wants to merge 2 commits into
aprv10 wants to merge 2 commits into
Conversation
Vaibhaav-Tiwari
left a comment
Collaborator
There was a problem hiding this comment.
apart from the redundant commits, lgtm
Contributor
Author
these commits are from the prettier auto format bot. I did not do that |
Collaborator
yup that's what i thought, it's fine |
Vaibhaav-Tiwari
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #2345
What was wrong
A worker session whose status is
pr_openordraftwas shown as a breathing orange "Working" pill in the session topbar and inspector — implying the agent is actively working — while the board files the same session under "In review" and the sidebar shows a neutral dot. Three surfaces, one contradictory reading: a session that has opened a PR and gone idle awaitingreview was animated as if it were busy coding.
Root cause: two status mappings handled these states differently, and the pill
used the one with no case for them.
attentionZonemapspr_open/draft→pending→ board "In review".workerDisplayStatushad no case forpr_open/draft, so they fell throughdefault: return "working"— the one bucket that is orange and breathes (STATUS_PILL.working = { breathe: true }).Both
ShellTopbarandSessionInspectorrender the pill viaworkerDisplayStatus, so both showed the misleading state.What this fixes
Adds a dedicated
in_reviewdisplay status coveringpr_openanddraft:workerDisplayStatusnow mapspr_open/draft→in_review.var(--fg-muted)tone rather than adding a new color, so the "1:1 to accent colors" rule in DESIGN.md still holds.No new color, no behavior change for any other status.
Testing
tsc --noEmit: clean — this alone proves everyRecord<WorkerDisplayStatus>map (both
STATUS_PILLs andworkerStatusLabel) got the new key.npx vitest run src/renderer(required frontend gate): 255/255 pass.pr_open/draft→in_reviewto theworkerDisplayStatusmappingtable and an
in_reviewcase to theworkerStatusPulsestest.Files
frontend/src/renderer/types/workspace.tsfrontend/src/renderer/components/ShellTopbar.tsxfrontend/src/renderer/components/SessionInspector.tsxfrontend/src/renderer/types/workspace.test.ts