Skip to content

fix(status): stop showing open-PR/draft sessions as "Working" in the status pill#2346

Open
aprv10 wants to merge 2 commits into
AgentWrapper:mainfrom
aprv10:fix/topbar-status-pill-open-pr
Open

fix(status): stop showing open-PR/draft sessions as "Working" in the status pill#2346
aprv10 wants to merge 2 commits into
AgentWrapper:mainfrom
aprv10:fix/topbar-status-pill-open-pr

Conversation

@aprv10

@aprv10 aprv10 commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Resolves #2345

What was wrong

A worker session whose status is pr_open or draft was shown as a breathing orange "Working" pill in the session topbar and inspector — implying the agent is actively working — while the board files the same session under "In review" and the sidebar shows a neutral dot. Three surfaces, one contradictory reading: a session that has opened a PR and gone idle awaiting
review was animated as if it were busy coding.

Root cause: two status mappings handled these states differently, and the pill
used the one with no case for them.

  • attentionZone maps pr_open/draftpending → board "In review".
  • workerDisplayStatus had no case for pr_open/draft, so they fell through default: return "working" — the one bucket that is orange and breathes (STATUS_PILL.working = { breathe: true }).

Both ShellTopbar and SessionInspector render the pill via workerDisplayStatus, so both showed the misleading state.

What this fixes

Adds a dedicated in_review display status covering pr_open and draft:

  • workerDisplayStatus now maps pr_open/draftin_review.
  • The pill renders "In review", muted, non-breathing — consistent with the board's "In review" column and the sidebar's neutral dot.
  • Reuses the existing var(--fg-muted) tone rather than adding a new color, so the "1:1 to accent colors" rule in DESIGN.md still holds.

No new color, no behavior change for any other status.

Testing

  • tsc --noEmit: clean — this alone proves every Record<WorkerDisplayStatus>
    map (both STATUS_PILLs and workerStatusLabel) got the new key.
  • npx vitest run src/renderer (required frontend gate): 255/255 pass.
  • Added pr_open/draftin_review to the workerDisplayStatus mapping
    table and an in_review case to the workerStatusPulses test.

Files

  • frontend/src/renderer/types/workspace.ts
  • frontend/src/renderer/components/ShellTopbar.tsx
  • frontend/src/renderer/components/SessionInspector.tsx
  • frontend/src/renderer/types/workspace.test.ts

@Vaibhaav-Tiwari Vaibhaav-Tiwari left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apart from the redundant commits, lgtm

Comment thread frontend/src/renderer/components/CreateProjectAgentSheet.tsx
Comment thread frontend/src/renderer/lib/agent-options.ts
@aprv10

aprv10 commented Jul 2, 2026

Copy link
Copy Markdown
Contributor Author

apart from the redundant commits, lgtm

these commits are from the prettier auto format bot. I did not do that

@Vaibhaav-Tiwari

Copy link
Copy Markdown
Collaborator

apart from the redundant commits, lgtm

these commits are from the prettier auto format bot. I did not do that

yup that's what i thought, it's fine
we gotta do something about prettier

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Topbar status pill shows orange "working" for open PR and draft sessions, contradicting the board's "In review" description

2 participants