-
Notifications
You must be signed in to change notification settings - Fork 0
fix(engine): make workspace creation resilient #333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
khaliqgant
wants to merge
8
commits into
main
Choose a base branch
from
fix/relay-1562-write-plane-0817
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,482
−33
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
1795e4e
fix(engine): make workspace creation resilient
f3af1d8
fix(engine): close workspace resilience review gaps
khaliqgant 67e2c91
fix(engine): fail closed on workspace id collisions
khaliqgant b2eadef
docs(trail): record PR 333 follow-up
khaliqgant 7b4794c
test(engine): stabilize workspace retry clock
khaliqgant af9c61f
docs(trail): record retry test stabilization
khaliqgant f2b371b
fix(engine): distinguish workspace readback outages
khaliqgant 743a171
docs(trail): record late PR 333 findings
khaliqgant File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
77 changes: 77 additions & 0 deletions
77
.agentworkforce/trajectories/completed/2026-08/traj_7j4ob7xwg0ot.trace.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,77 @@ | ||
| { | ||
| "version": "1.0.0", | ||
| "id": "632139b6-0bda-4558-a8ad-31a2aa1fa606", | ||
| "timestamp": "2026-08-18T09:19:00.798Z", | ||
| "trajectory": "traj_7j4ob7xwg0ot", | ||
| "files": [ | ||
| { | ||
| "path": "packages/engine/src/engine/__tests__/workspace.test.ts", | ||
| "conversations": [ | ||
| { | ||
| "contributor": { | ||
| "type": "ai" | ||
| }, | ||
| "ranges": [ | ||
| { | ||
| "start_line": 9, | ||
| "end_line": 15, | ||
| "revision": "f2b371bd1267a9bd41a2221b4e110772c40258a1" | ||
| }, | ||
| { | ||
| "start_line": 24, | ||
| "end_line": 30, | ||
| "revision": "f2b371bd1267a9bd41a2221b4e110772c40258a1" | ||
| }, | ||
| { | ||
| "start_line": 84, | ||
| "end_line": 98, | ||
| "revision": "f2b371bd1267a9bd41a2221b4e110772c40258a1" | ||
| }, | ||
| { | ||
| "start_line": 128, | ||
| "end_line": 134, | ||
| "revision": "f2b371bd1267a9bd41a2221b4e110772c40258a1" | ||
| }, | ||
| { | ||
| "start_line": 147, | ||
| "end_line": 153, | ||
| "revision": "f2b371bd1267a9bd41a2221b4e110772c40258a1" | ||
| }, | ||
| { | ||
| "start_line": 180, | ||
| "end_line": 212, | ||
| "revision": "f2b371bd1267a9bd41a2221b4e110772c40258a1" | ||
| } | ||
| ] | ||
| } | ||
| ] | ||
| }, | ||
| { | ||
| "path": "packages/engine/src/engine/workspace.ts", | ||
| "conversations": [ | ||
| { | ||
| "contributor": { | ||
| "type": "ai" | ||
| }, | ||
| "ranges": [ | ||
| { | ||
| "start_line": 14, | ||
| "end_line": 24, | ||
| "revision": "f2b371bd1267a9bd41a2221b4e110772c40258a1" | ||
| }, | ||
| { | ||
| "start_line": 73, | ||
| "end_line": 90, | ||
| "revision": "f2b371bd1267a9bd41a2221b4e110772c40258a1" | ||
| }, | ||
| { | ||
| "start_line": 195, | ||
| "end_line": 221, | ||
| "revision": "f2b371bd1267a9bd41a2221b4e110772c40258a1" | ||
| } | ||
| ] | ||
| } | ||
| ] | ||
| } | ||
| ] | ||
| } |
45 changes: 45 additions & 0 deletions
45
.agentworkforce/trajectories/completed/2026-08/traj_7j4ob7xwg0ot/summary.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,45 @@ | ||
| # Trajectory: Address late PR #333 review findings | ||
|
|
||
| > **Status:** ✅ Completed | ||
| > **Task:** relaycast#333 | ||
| > **Confidence:** 96% | ||
| > **Started:** August 18, 2026 at 11:15 AM | ||
| > **Completed:** August 18, 2026 at 11:19 AM | ||
|
|
||
| --- | ||
|
|
||
| ## Summary | ||
|
|
||
| Separated exact-pair readback outages from proven ID mismatches, decoupled collision tests from Snowflake internals, and corrected validation provenance. | ||
|
|
||
| **Approach:** Standard approach | ||
|
|
||
| --- | ||
|
|
||
| ## Key Decisions | ||
|
|
||
| ### Model committed-pair readback as match, mismatch, or unavailable | ||
| - **Chose:** Model committed-pair readback as match, mismatch, or unavailable | ||
| - **Reasoning:** A unique conflict plus a failed read cannot establish an identifier collision; only a successful mismatched read can. The unavailable state must preserve the documented indeterminate 503 outcome. | ||
|
|
||
| ### Stub createWorkspace's generated IDs in collision tests | ||
| - **Chose:** Stub createWorkspace's generated IDs in collision tests | ||
| - **Reasoning:** Explicit IDs exercise the real call boundary without depending on the Snowflake singleton's private sequence arithmetic or call ordering. | ||
|
|
||
| --- | ||
|
|
||
| ## Chapters | ||
|
|
||
| ### 1. Work | ||
| *Agent: default* | ||
|
|
||
| - Model committed-pair readback as match, mismatch, or unavailable: Model committed-pair readback as match, mismatch, or unavailable | ||
| - Stub createWorkspace's generated IDs in collision tests: Stub createWorkspace's generated IDs in collision tests | ||
| - The readback-outage regression failed before the fix with workspace_id_collision and now returns the documented 503; collision stubs exercise explicit IDs, and focused plus full-engine gates pass. | ||
|
|
||
| --- | ||
|
|
||
| ## Artifacts | ||
|
|
||
| **Commits:** f2b371b | ||
| **Files changed:** 2 | ||
97 changes: 97 additions & 0 deletions
97
.agentworkforce/trajectories/completed/2026-08/traj_7j4ob7xwg0ot/trajectory.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,97 @@ | ||
| { | ||
| "id": "traj_7j4ob7xwg0ot", | ||
| "version": 1, | ||
| "task": { | ||
| "title": "Address late PR #333 review findings", | ||
| "source": { | ||
| "system": "plain", | ||
| "id": "relaycast#333" | ||
| } | ||
| }, | ||
| "status": "completed", | ||
| "startedAt": "2026-08-18T09:15:58.632Z", | ||
| "completedAt": "2026-08-18T09:19:00.741Z", | ||
| "agents": [ | ||
| { | ||
| "name": "default", | ||
| "role": "lead", | ||
| "joinedAt": "2026-08-18T09:16:06.956Z" | ||
| } | ||
| ], | ||
| "chapters": [ | ||
| { | ||
| "id": "chap_uhrrwzdpr86v", | ||
| "title": "Work", | ||
| "agentName": "default", | ||
| "startedAt": "2026-08-18T09:16:06.956Z", | ||
| "endedAt": "2026-08-18T09:19:00.741Z", | ||
| "events": [ | ||
| { | ||
| "ts": 1787044566957, | ||
| "type": "decision", | ||
| "content": "Model committed-pair readback as match, mismatch, or unavailable: Model committed-pair readback as match, mismatch, or unavailable", | ||
| "raw": { | ||
| "question": "Model committed-pair readback as match, mismatch, or unavailable", | ||
| "chosen": "Model committed-pair readback as match, mismatch, or unavailable", | ||
| "alternatives": [], | ||
| "reasoning": "A unique conflict plus a failed read cannot establish an identifier collision; only a successful mismatched read can. The unavailable state must preserve the documented indeterminate 503 outcome." | ||
| }, | ||
| "significance": "high" | ||
| }, | ||
| { | ||
| "ts": 1787044567210, | ||
| "type": "decision", | ||
| "content": "Stub createWorkspace's generated IDs in collision tests: Stub createWorkspace's generated IDs in collision tests", | ||
| "raw": { | ||
| "question": "Stub createWorkspace's generated IDs in collision tests", | ||
| "chosen": "Stub createWorkspace's generated IDs in collision tests", | ||
| "alternatives": [], | ||
| "reasoning": "Explicit IDs exercise the real call boundary without depending on the Snowflake singleton's private sequence arithmetic or call ordering." | ||
| }, | ||
| "significance": "high" | ||
| }, | ||
| { | ||
| "ts": 1787044740501, | ||
| "type": "reflection", | ||
| "content": "The readback-outage regression failed before the fix with workspace_id_collision and now returns the documented 503; collision stubs exercise explicit IDs, and focused plus full-engine gates pass.", | ||
| "raw": { | ||
| "focalPoints": [ | ||
| "readback-outage", | ||
| "collision-semantics", | ||
| "test-isolation", | ||
| "provenance" | ||
| ], | ||
| "confidence": 0.96 | ||
| }, | ||
| "significance": "high", | ||
| "tags": [ | ||
| "focal:readback-outage", | ||
| "focal:collision-semantics", | ||
| "focal:test-isolation", | ||
| "focal:provenance", | ||
| "confidence:0.96" | ||
| ] | ||
| } | ||
| ] | ||
| } | ||
| ], | ||
| "retrospective": { | ||
| "summary": "Separated exact-pair readback outages from proven ID mismatches, decoupled collision tests from Snowflake internals, and corrected validation provenance.", | ||
| "approach": "Standard approach", | ||
| "confidence": 0.96 | ||
| }, | ||
| "commits": [ | ||
| "f2b371b" | ||
| ], | ||
| "filesChanged": [ | ||
| "packages/engine/src/engine/__tests__/workspace.test.ts", | ||
| "packages/engine/src/engine/workspace.ts" | ||
| ], | ||
| "projectId": "AgentWorkforce/relaycast", | ||
| "tags": [], | ||
| "_trace": { | ||
| "startRef": "af9c61fd33dfdd8e3ba3578a7d5d850804121596", | ||
| "endRef": "f2b371bd1267a9bd41a2221b4e110772c40258a1", | ||
| "traceId": "632139b6-0bda-4558-a8ad-31a2aa1fa606" | ||
| } | ||
| } |
25 changes: 25 additions & 0 deletions
25
.agentworkforce/trajectories/completed/2026-08/traj_a8ldf56q5b68.trace.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| { | ||
| "version": "1.0.0", | ||
| "id": "4cce42d1-fcdf-41c1-8b46-7b792240ef1e", | ||
| "timestamp": "2026-08-18T09:04:41.523Z", | ||
| "trajectory": "traj_a8ldf56q5b68", | ||
| "files": [ | ||
| { | ||
| "path": "packages/engine/src/engine/__tests__/workspace.test.ts", | ||
| "conversations": [ | ||
| { | ||
| "contributor": { | ||
| "type": "ai" | ||
| }, | ||
| "ranges": [ | ||
| { | ||
| "start_line": 179, | ||
| "end_line": 185, | ||
| "revision": "7b4794c14a95f657bb925612bef0b6de36bf569f" | ||
| } | ||
| ] | ||
| } | ||
| ] | ||
| } | ||
| ] | ||
| } |
40 changes: 40 additions & 0 deletions
40
.agentworkforce/trajectories/completed/2026-08/traj_a8ldf56q5b68/summary.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| # Trajectory: Stabilize PR #333 lost-response recovery regression | ||
|
|
||
| > **Status:** ✅ Completed | ||
| > **Task:** relaycast#333 | ||
| > **Confidence:** 96% | ||
| > **Started:** August 18, 2026 at 11:03 AM | ||
| > **Completed:** August 18, 2026 at 11:04 AM | ||
|
|
||
| --- | ||
|
|
||
| ## Summary | ||
|
|
||
| Stabilized the lost-response retry regression under full-suite load and revalidated all local gates. | ||
|
|
||
| **Approach:** Standard approach | ||
|
|
||
| --- | ||
|
|
||
| ## Key Decisions | ||
|
|
||
| ### Auto-advance the fake retry clock | ||
| - **Chose:** Auto-advance the fake retry clock | ||
| - **Reasoning:** The test started timer advancement before asynchronous key hashing had necessarily scheduled the first retry; auto-advancing fake time preserves fast deterministic backoff under full-suite load. | ||
|
|
||
| --- | ||
|
|
||
| ## Chapters | ||
|
|
||
| ### 1. Work | ||
| *Agent: default* | ||
|
|
||
| - Auto-advance the fake retry clock: Auto-advance the fake retry clock | ||
| - The full monorepo test exposed a timer-start race in the lost-response regression; auto-advancing fake time removed the race, and focused, full-engine, build, lint, and test gates now pass. | ||
|
|
||
| --- | ||
|
|
||
| ## Artifacts | ||
|
|
||
| **Commits:** 7b4794c | ||
| **Files changed:** 1 |
82 changes: 82 additions & 0 deletions
82
.agentworkforce/trajectories/completed/2026-08/traj_a8ldf56q5b68/trajectory.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,82 @@ | ||
| { | ||
| "id": "traj_a8ldf56q5b68", | ||
| "version": 1, | ||
| "task": { | ||
| "title": "Stabilize PR #333 lost-response recovery regression", | ||
| "source": { | ||
| "system": "plain", | ||
| "id": "relaycast#333" | ||
| } | ||
| }, | ||
| "status": "completed", | ||
| "startedAt": "2026-08-18T09:03:51.053Z", | ||
| "completedAt": "2026-08-18T09:04:41.430Z", | ||
| "agents": [ | ||
| { | ||
| "name": "default", | ||
| "role": "lead", | ||
| "joinedAt": "2026-08-18T09:03:56.543Z" | ||
| } | ||
| ], | ||
| "chapters": [ | ||
| { | ||
| "id": "chap_7yrkxksb7ani", | ||
| "title": "Work", | ||
| "agentName": "default", | ||
| "startedAt": "2026-08-18T09:03:56.543Z", | ||
| "endedAt": "2026-08-18T09:04:41.430Z", | ||
| "events": [ | ||
| { | ||
| "ts": 1787043836544, | ||
| "type": "decision", | ||
| "content": "Auto-advance the fake retry clock: Auto-advance the fake retry clock", | ||
| "raw": { | ||
| "question": "Auto-advance the fake retry clock", | ||
| "chosen": "Auto-advance the fake retry clock", | ||
| "alternatives": [], | ||
| "reasoning": "The test started timer advancement before asynchronous key hashing had necessarily scheduled the first retry; auto-advancing fake time preserves fast deterministic backoff under full-suite load." | ||
| }, | ||
| "significance": "high" | ||
| }, | ||
| { | ||
| "ts": 1787043881146, | ||
| "type": "reflection", | ||
| "content": "The full monorepo test exposed a timer-start race in the lost-response regression; auto-advancing fake time removed the race, and focused, full-engine, build, lint, and test gates now pass.", | ||
| "raw": { | ||
| "focalPoints": [ | ||
| "test-determinism", | ||
| "retry-coverage", | ||
| "verification" | ||
| ], | ||
| "confidence": 0.96 | ||
| }, | ||
| "significance": "high", | ||
| "tags": [ | ||
| "focal:test-determinism", | ||
| "focal:retry-coverage", | ||
| "focal:verification", | ||
| "confidence:0.96" | ||
| ] | ||
| } | ||
| ] | ||
| } | ||
| ], | ||
| "retrospective": { | ||
| "summary": "Stabilized the lost-response retry regression under full-suite load and revalidated all local gates.", | ||
| "approach": "Standard approach", | ||
| "confidence": 0.96 | ||
| }, | ||
| "commits": [ | ||
| "7b4794c" | ||
| ], | ||
| "filesChanged": [ | ||
| "packages/engine/src/engine/__tests__/workspace.test.ts" | ||
| ], | ||
| "projectId": "AgentWorkforce/relaycast", | ||
| "tags": [], | ||
| "_trace": { | ||
| "startRef": "b2eadefa957626305a54d641d4baa3989f395341", | ||
| "endRef": "7b4794c14a95f657bb925612bef0b6de36bf569f", | ||
| "traceId": "4cce42d1-fcdf-41c1-8b46-7b792240ef1e" | ||
| } | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.