-
Notifications
You must be signed in to change notification settings - Fork 64
fix(broker): resolve repo assignments on the receiving node #1578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
3c0f2f9
fix(broker): resolve assignment repos locally
miyaontherelay 2ec5daa
fix(cli): pass node repo paths to broker
miyaontherelay feda644
Add private repo path registration
32ba6f8
Merge remote-tracking branch 'origin/agent/placement-relay-wire-0819'…
miyaontherelay 40a87d7
feat(fleet): add privacy-safe repository registration
e9f8721
feat(fleet): add privacy-safe repository registration
eea1d8c
fix(broker): complete node-local repo placement
7517bbb
fix(fleet): harden repository registration boundary
4ddaf31
fix(broker): enforce local repository placement
miyaontherelay c209e27
Merge remote-tracking branch 'origin/feature/node-local-repo-resoluti…
miyaontherelay c4ec7b7
fix(protocol): reject malformed repo placement
da43ca7
Merge remote-tracking branch 'origin/feature/node-local-repo-resoluti…
miyaontherelay e1af768
style: auto-format with Prettier
github-actions[bot] ffda1b9
merge: stack node repository resolver on wire contract
8f58e7e
test(fleet): remove invalid duplicate fixtures
63a6fb4
merge: reconcile concurrent node placement fixes
8c10491
merge: absorb final concurrent resolver cleanup
0e6ced8
chore(trajectory): record node repo resolution work
643bf88
fix(broker): preserve repo map configuration presence
b606c04
Merge final repo map presence fix
148ce53
merge: absorb origin/main (v11.8.0, privacy-safe repo registration #1…
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
31 changes: 31 additions & 0 deletions
31
.agentworkforce/trajectories/completed/2026-08/traj_5ga3aenlthf7/summary.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| # Trajectory: Implement node-local repo registration contract | ||
|
|
||
| > **Status:** ✅ Completed | ||
| > **Confidence:** 95% | ||
| > **Started:** August 19, 2026 at 09:03 AM | ||
| > **Completed:** August 19, 2026 at 09:26 AM | ||
|
|
||
| --- | ||
|
|
||
| ## Summary | ||
|
|
||
| Added validated node-local repoPaths configuration and path-free repo tag registration in the Fleet SDK, with compatibility, privacy serialization tests, docs, and changelog. | ||
|
|
||
| **Approach:** Standard approach | ||
|
|
||
| --- | ||
|
|
||
| ## Key Decisions | ||
|
|
||
| ### Use repoPaths as the node-local TypeScript config and emit only derived repo:<owner/name> tags | ||
| - **Chose:** Use repoPaths as the node-local TypeScript config and emit only derived repo:<owner/name> tags | ||
| - **Reasoning:** Relaycast's current registration path already persists repo tags and Relay's installed NodeProviderClient supports tags but not repo_keys; the companion node-resolution lane owns the private broker handoff. | ||
|
|
||
| --- | ||
|
|
||
| ## Chapters | ||
|
|
||
| ### 1. Work | ||
| *Agent: default* | ||
|
|
||
| - Use repoPaths as the node-local TypeScript config and emit only derived repo:<owner/name> tags: Use repoPaths as the node-local TypeScript config and emit only derived repo:<owner/name> tags | ||
53 changes: 53 additions & 0 deletions
53
.agentworkforce/trajectories/completed/2026-08/traj_5ga3aenlthf7/trajectory.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,53 @@ | ||
| { | ||
| "id": "traj_5ga3aenlthf7", | ||
| "version": 1, | ||
| "task": { | ||
| "title": "Implement node-local repo registration contract" | ||
| }, | ||
| "status": "completed", | ||
| "startedAt": "2026-08-19T07:03:27.927Z", | ||
| "completedAt": "2026-08-19T07:26:07.341Z", | ||
| "agents": [ | ||
| { | ||
| "name": "default", | ||
| "role": "lead", | ||
| "joinedAt": "2026-08-19T07:14:24.184Z" | ||
| } | ||
| ], | ||
| "chapters": [ | ||
| { | ||
| "id": "chap_aix2fv0fj01l", | ||
| "title": "Work", | ||
| "agentName": "default", | ||
| "startedAt": "2026-08-19T07:14:24.184Z", | ||
| "endedAt": "2026-08-19T07:26:07.341Z", | ||
| "events": [ | ||
| { | ||
| "ts": 1787123664185, | ||
| "type": "decision", | ||
| "content": "Use repoPaths as the node-local TypeScript config and emit only derived repo:<owner/name> tags: Use repoPaths as the node-local TypeScript config and emit only derived repo:<owner/name> tags", | ||
| "raw": { | ||
| "question": "Use repoPaths as the node-local TypeScript config and emit only derived repo:<owner/name> tags", | ||
| "chosen": "Use repoPaths as the node-local TypeScript config and emit only derived repo:<owner/name> tags", | ||
| "alternatives": [], | ||
| "reasoning": "Relaycast's current registration path already persists repo tags and Relay's installed NodeProviderClient supports tags but not repo_keys; the companion node-resolution lane owns the private broker handoff." | ||
|
coderabbitai[bot] marked this conversation as resolved.
|
||
| }, | ||
| "significance": "high" | ||
| } | ||
| ] | ||
| } | ||
| ], | ||
| "retrospective": { | ||
| "summary": "Added validated node-local repoPaths configuration and path-free repo tag registration in the Fleet SDK, with compatibility, privacy serialization tests, docs, and changelog.", | ||
| "approach": "Standard approach", | ||
| "confidence": 0.95 | ||
| }, | ||
| "commits": [], | ||
| "filesChanged": [], | ||
|
coderabbitai[bot] marked this conversation as resolved.
|
||
| "projectId": "AgentWorkforce/relay", | ||
| "tags": [], | ||
| "_trace": { | ||
| "startRef": "286467e936bb3efbd415ed233d416e59cd390c05", | ||
| "endRef": "286467e936bb3efbd415ed233d416e59cd390c05" | ||
| } | ||
| } | ||
245 changes: 245 additions & 0 deletions
245
.agentworkforce/trajectories/completed/2026-08/traj_bgak19d8cp7m.trace.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,245 @@ | ||
| { | ||
| "version": "1.0.0", | ||
| "id": "6719de3e-e2f6-4c3a-81a3-2e62d82a5e6d", | ||
| "timestamp": "2026-08-19T08:07:14.777Z", | ||
| "trajectory": "traj_bgak19d8cp7m", | ||
| "files": [ | ||
| { | ||
| "path": "crates/broker/src/runtime/event_loop.rs", | ||
| "conversations": [ | ||
| { | ||
| "contributor": { | ||
| "type": "ai" | ||
| }, | ||
| "ranges": [ | ||
| { | ||
| "start_line": 209, | ||
| "end_line": 217, | ||
| "revision": "f57210bd016748099d7505ff6d59e68d61c3cad3" | ||
| } | ||
| ] | ||
| } | ||
| ] | ||
| }, | ||
| { | ||
| "path": "crates/broker/src/runtime/fleet.rs", | ||
| "conversations": [ | ||
| { | ||
| "contributor": { | ||
| "type": "ai" | ||
| }, | ||
| "ranges": [ | ||
| { | ||
| "start_line": 1255, | ||
| "end_line": 1261, | ||
| "revision": "f57210bd016748099d7505ff6d59e68d61c3cad3" | ||
| } | ||
| ] | ||
| } | ||
| ] | ||
| }, | ||
| { | ||
| "path": "crates/broker/src/runtime/init.rs", | ||
| "conversations": [ | ||
| { | ||
| "contributor": { | ||
| "type": "ai" | ||
| }, | ||
| "ranges": [ | ||
| { | ||
| "start_line": 273, | ||
| "end_line": 279, | ||
| "revision": "f57210bd016748099d7505ff6d59e68d61c3cad3" | ||
| }, | ||
| { | ||
| "start_line": 681, | ||
| "end_line": 687, | ||
| "revision": "f57210bd016748099d7505ff6d59e68d61c3cad3" | ||
| } | ||
| ] | ||
| } | ||
| ] | ||
| }, | ||
| { | ||
| "path": "crates/broker/src/runtime/mod.rs", | ||
| "conversations": [ | ||
| { | ||
| "contributor": { | ||
| "type": "ai" | ||
| }, | ||
| "ranges": [ | ||
| { | ||
| "start_line": 83, | ||
| "end_line": 89, | ||
| "revision": "f57210bd016748099d7505ff6d59e68d61c3cad3" | ||
| } | ||
| ] | ||
| } | ||
| ] | ||
| }, | ||
| { | ||
| "path": "crates/broker/src/runtime/relaycast_events.rs", | ||
| "conversations": [ | ||
| { | ||
| "contributor": { | ||
| "type": "ai" | ||
| }, | ||
| "ranges": [ | ||
| { | ||
| "start_line": 71, | ||
| "end_line": 83, | ||
| "revision": "f57210bd016748099d7505ff6d59e68d61c3cad3" | ||
| }, | ||
| { | ||
| "start_line": 428, | ||
| "end_line": 434, | ||
| "revision": "f57210bd016748099d7505ff6d59e68d61c3cad3" | ||
| }, | ||
| { | ||
| "start_line": 471, | ||
| "end_line": 477, | ||
| "revision": "f57210bd016748099d7505ff6d59e68d61c3cad3" | ||
| }, | ||
| { | ||
| "start_line": 1164, | ||
| "end_line": 1170, | ||
| "revision": "f57210bd016748099d7505ff6d59e68d61c3cad3" | ||
| }, | ||
| { | ||
| "start_line": 1242, | ||
| "end_line": 1248, | ||
| "revision": "f57210bd016748099d7505ff6d59e68d61c3cad3" | ||
| }, | ||
| { | ||
| "start_line": 1256, | ||
| "end_line": 1265, | ||
| "revision": "f57210bd016748099d7505ff6d59e68d61c3cad3" | ||
| }, | ||
| { | ||
| "start_line": 1267, | ||
| "end_line": 1278, | ||
| "revision": "f57210bd016748099d7505ff6d59e68d61c3cad3" | ||
| } | ||
| ] | ||
| } | ||
| ] | ||
| }, | ||
| { | ||
| "path": "crates/broker/src/runtime/repo_placement.rs", | ||
| "conversations": [ | ||
| { | ||
| "contributor": { | ||
| "type": "ai" | ||
| }, | ||
| "ranges": [ | ||
| { | ||
| "start_line": 1, | ||
| "end_line": 285, | ||
| "revision": "f57210bd016748099d7505ff6d59e68d61c3cad3" | ||
| } | ||
| ] | ||
| } | ||
| ] | ||
| }, | ||
| { | ||
| "path": "crates/broker/src/runtime/tests.rs", | ||
| "conversations": [ | ||
| { | ||
| "contributor": { | ||
| "type": "ai" | ||
| }, | ||
| "ranges": [ | ||
| { | ||
| "start_line": 265, | ||
| "end_line": 271, | ||
| "revision": "f57210bd016748099d7505ff6d59e68d61c3cad3" | ||
| } | ||
| ] | ||
| } | ||
| ] | ||
| }, | ||
| { | ||
| "path": "packages/cli/src/cli/lib/broker-lifecycle.test.ts", | ||
| "conversations": [ | ||
| { | ||
| "contributor": { | ||
| "type": "ai" | ||
| }, | ||
| "ranges": [ | ||
| { | ||
| "start_line": 520, | ||
| "end_line": 541, | ||
| "revision": "f57210bd016748099d7505ff6d59e68d61c3cad3" | ||
| } | ||
| ] | ||
| } | ||
| ] | ||
| }, | ||
| { | ||
| "path": "packages/cli/src/cli/lib/broker-lifecycle.ts", | ||
| "conversations": [ | ||
| { | ||
| "contributor": { | ||
| "type": "ai" | ||
| }, | ||
| "ranges": [ | ||
| { | ||
| "start_line": 1513, | ||
| "end_line": 1527, | ||
| "revision": "f57210bd016748099d7505ff6d59e68d61c3cad3" | ||
| }, | ||
| { | ||
| "start_line": 1889, | ||
| "end_line": 1902, | ||
| "revision": "f57210bd016748099d7505ff6d59e68d61c3cad3" | ||
| } | ||
| ] | ||
| } | ||
| ] | ||
| }, | ||
| { | ||
| "path": "packages/cli/src/cli/lib/node-provider-child.test.ts", | ||
| "conversations": [ | ||
| { | ||
| "contributor": { | ||
| "type": "ai" | ||
| }, | ||
| "ranges": [ | ||
| { | ||
| "start_line": 177, | ||
| "end_line": 214, | ||
| "revision": "f57210bd016748099d7505ff6d59e68d61c3cad3" | ||
| } | ||
| ] | ||
| } | ||
| ] | ||
| }, | ||
| { | ||
| "path": "packages/cli/src/cli/lib/node-provider-child.ts", | ||
| "conversations": [ | ||
| { | ||
| "contributor": { | ||
| "type": "ai" | ||
| }, | ||
| "ranges": [ | ||
| { | ||
| "start_line": 115, | ||
| "end_line": 123, | ||
| "revision": "f57210bd016748099d7505ff6d59e68d61c3cad3" | ||
| }, | ||
| { | ||
| "start_line": 259, | ||
| "end_line": 266, | ||
| "revision": "f57210bd016748099d7505ff6d59e68d61c3cad3" | ||
| }, | ||
| { | ||
| "start_line": 278, | ||
| "end_line": 296, | ||
| "revision": "f57210bd016748099d7505ff6d59e68d61c3cad3" | ||
| } | ||
| ] | ||
| } | ||
| ] | ||
| } | ||
| ] | ||
| } |
39 changes: 39 additions & 0 deletions
39
.agentworkforce/trajectories/completed/2026-08/traj_bgak19d8cp7m/summary.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| # Trajectory: Resolve assigned repositories on fleet nodes before spawn | ||
|
|
||
| > **Status:** ✅ Completed | ||
| > **Confidence:** 95% | ||
| > **Started:** August 19, 2026 at 09:01 AM | ||
| > **Completed:** August 19, 2026 at 10:07 AM | ||
|
|
||
| --- | ||
|
|
||
| ## Summary | ||
|
|
||
| Implemented node-local repository assignment resolution with private repo map ingestion, key-only registration, fail-closed spawn validation, malicious cwd rejection, and focused Rust/CLI coverage; integrated the wire parent and passed format, typecheck, clippy, and tests. | ||
|
|
||
| **Approach:** Standard approach | ||
|
|
||
| --- | ||
|
|
||
| ## Key Decisions | ||
|
|
||
| ### Keep repository paths node-private and resolve only assignment keys at the final spawn boundary | ||
| - **Chose:** Keep repository paths node-private and resolve only assignment keys at the final spawn boundary | ||
| - **Reasoning:** Factory-provided cwd variants cross a trust boundary; loading and consuming the node-local map at broker startup prevents path disclosure and inheritance, while spawn-time filesystem checks fail closed if checkout state changes. | ||
|
|
||
| --- | ||
|
|
||
| ## Chapters | ||
|
|
||
| ### 1. Work | ||
| *Agent: default* | ||
|
|
||
| - Keep repository paths node-private and resolve only assignment keys at the final spawn boundary: Keep repository paths node-private and resolve only assignment keys at the final spawn boundary | ||
| - Integrated the complete wire parent before finalizing the node lane; the final diff is limited to node-local ingestion, registration key derivation, CLI env bridging, and authoritative spawn resolution. | ||
|
|
||
| --- | ||
|
|
||
| ## Artifacts | ||
|
|
||
| **Commits:** f57210bd0 | ||
| **Files changed:** 11 |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.