Skip to content

chore: stop format-gating generated trajectory artifacts - #1530

Merged
khaliqgant merged 1 commit into
mainfrom
chore/prettierignore-trajectories
Aug 15, 2026
Merged

chore: stop format-gating generated trajectory artifacts#1530
khaliqgant merged 1 commit into
mainfrom
chore/prettierignore-trajectories

Conversation

@khaliqgant

@khaliqgant khaliqgant commented Aug 15, 2026

Copy link
Copy Markdown
Member

format:check currently fails on main, so every open PR fails Prettier regardless of what it changes:

[warn] .agentworkforce/trajectories/task-1507/completed/2026-08/traj_esvqzlbnhqbt/summary.md
[warn] .agentworkforce/trajectories/task-1507/completed/2026-08/traj_esvqzlbnhqbt/trajectory.json

Those files were committed by #1520 at 2026-08-15 20:34 and are generated agent runtime output, not source. .prettierignore had no rule covering them.

Reformatting them would be the wrong fix — they are regenerated on every run, so the next trajectory reintroduces the failure. Ignoring the directory matches how the file already treats dist/, target/ and packages/config/src/cli-registry.generated.ts.

Verified: with this rule, prettier --check on both named files reports All matched files use Prettier code style!

Related: #1385 adds the matching .gitignore rule; this is the formatter half. Unblocks #1529, which touches one Rust file and fails only on this.

Not merged — Khaliq owns the gate.

🤖 Generated with Claude Code

Review in cubic

`format:check` fails on main:

    [warn] .agentworkforce/trajectories/task-1507/completed/2026-08/traj_esvqzlbnhqbt/summary.md
    [warn] .agentworkforce/trajectories/task-1507/completed/2026-08/traj_esvqzlbnhqbt/trajectory.json

Those files were committed by #1520 at 2026-08-15 20:34 and are generated
agent runtime output, not source. Prettier had no ignore rule for them, so
every open PR now fails Prettier regardless of what it changed — relay#1529
touches one Rust file and fails on this.

Reformatting them would be wrong: they are regenerated on every run, so the
next trajectory reintroduces the failure. Ignore the directory instead,
alongside the other generated paths already listed.

Related: #1385 adds the matching .gitignore rule; this is the formatter half.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@cursor

cursor Bot commented Aug 15, 2026

Copy link
Copy Markdown

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

@coderabbitai

coderabbitai Bot commented Aug 15, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: fb562c4d-1d86-4e1a-aacd-b74e9cbdd904

📥 Commits

Reviewing files that changed from the base of the PR and between adf2846 and a66f4d4.

📒 Files selected for processing (1)
  • .prettierignore

📝 Walkthrough

Walkthrough

The Prettier ignore configuration now excludes .agentworkforce/trajectories/.

Changes

Prettier ignore rules

Layer / File(s) Summary
Ignore trajectory artifacts
.prettierignore
Adds .agentworkforce/trajectories/ to the ignored paths.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to a66f4

This is a narrowly scoped formatter-ignore change for generated artifacts, with no actionable merge-blocking risk remaining beyond normal checks and review.

Possibly related PRs

Suggested reviewers: willwashburn

Poem

A rabbit checks the format trail,
And keeps the trajectory files from the sail.
Prettier hops past the marked-out way,
While clean paths guide the code each day.
- 🐇

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description check ✅ Passed The description explains the change, its reason, verification, and related issues; the missing template headings are non-critical.
Title check ✅ Passed The title clearly and concisely describes excluding generated trajectory artifacts from formatting checks.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/prettierignore-trajectories

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Re-trigger cubic

@khaliqgant
khaliqgant merged commit 92fd2db into main Aug 15, 2026
31 checks passed
@khaliqgant
khaliqgant deleted the chore/prettierignore-trajectories branch August 15, 2026 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant