fix(workflows): import @relayflows/core instead of the removed sdk subpath - #112
Conversation
…bpath
linear-chat-lead.ts opened with `import { workflow } from
'@agent-relay/sdk/workflows'`, which cannot resolve: `@agent-relay/sdk` exports
`.`, `./messaging`, `./delivery`, `./actions`, `./session`, and `./capabilities`
and has no `./workflows` subpath. cloud/scripts/smoke-sandbox-image.mjs records
that `@relayflows/core` "replaces the removed @agent-relay/sdk/workflows".
workflows/agent-relay-workflows.d.ts existed only to paper over that: a
hand-written `declare module '@agent-relay/sdk/workflows'` stub with `type
StepOptions = Record<string, unknown>`, which meant every step in our reference
workflow was typed as an untyped bag and typos in step options could not be
caught. Deleted in favour of the real types.
Adds @relayflows/core as a dependency so the reference workflow typechecks
against the shipping API rather than a local approximation.
Verified: `tsc --noEmit -p tsconfig.json` exits 0.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (3)
💤 Files with no reviewable changes (1)
Included review availability: Your plan includes up to 1 review per rolling hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe workflow now uses ChangesRelayflows migration
Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to This localized dependency and import correction removes a non-resolving module reference and uses the shipping workflow types; no actionable merge-blocking risk remains after normal checks and review. Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1327d5f983
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "@relayfile/adapter-daytona": "^0.1.1", | ||
| "@relayfile/relay-helpers": "0.4.6" | ||
| "@relayfile/relay-helpers": "0.4.6", | ||
| "@relayflows/core": "^1.0.6" |
There was a problem hiding this comment.
Align Relayflows with the pinned Workforce packages
When this dependency is installed, the existing global override in package.json forces @agentworkforce/persona-kit 4.1.23 into every consumer, but the new core package declares ^4.1.39, and its newly introduced @agentworkforce/persona-registry 4.1.43 requires persona-kit exactly 4.1.43 (package-lock.json lines 370-376 and 4294-4305). npm overrides suppress that incompatibility, so a fresh install can succeed while the Linear workflow loads core/registry against a persona-kit older than their declared minimum and may fail on newer APIs at startup. Use a Relayflows version compatible with 4.1.23 or update the Workforce pins and overrides together.
Useful? React with 👍 / 👎.
|
Confirmed — this is a real conflict and I'm not merging it as-is. The global override pins persona-kit below Neither half of this PR is independently shippable:
Proposed split
I'd rather leave the stale import in place for now than paper over a dependency conflict with an override; the stale import fails loudly and immediately, whereas this would fail at agent startup. Companion fixes already merged: AgentWorkforce/relayflows#31–34, AgentWorkforce/relayfile#430, AgentWorkforce/skills#97 (which fixed the same stale specifier in the docs and in |
Summary
workflows/linear-chat-lead.ts— our reference workflow — opened withimport { workflow } from '@agent-relay/sdk/workflows', which cannot resolve.@agent-relay/sdkexports.,./messaging,./delivery,./actions,./session, and./capabilitiesand has no./workflowssubpath. Verified against published11.6.10and monorepo source11.6.2, which has nopackages/sdk/src/workflowsdirectory at all.cloud/scripts/smoke-sandbox-image.mjsrecords the replacement:Why the stub had to go
workflows/agent-relay-workflows.d.tsexisted only to paper over the missing module — a hand-writtendeclare module '@agent-relay/sdk/workflows'with:So every step in our reference workflow was typed as an untyped bag, and a typo in any step option could not be caught. Deleted in favour of the real types.
Changes
workflows/linear-chat-lead.ts: import from@relayflows/coreworkflows/agent-relay-workflows.d.ts@relayflows/coreas a dependency so the reference workflow typechecks against the shipping API rather than a local approximationVerification
tsc --noEmit -p tsconfig.jsonexits 0 (workflows/*.tsis ininclude, so the reference workflow is genuinely covered now).Companion doc fix: AgentWorkforce/skills — the workflow-authoring skills carried the same stale import.
🤖 Generated with Claude Code
Summary by cubic
Fixes the broken workflow import by switching from the removed
@agent-relay/sdk/workflowssubpath to@relayflows/core, and removes the local type stub so the reference workflow typechecks against the real API. Previously the import failed and step options were untyped; now the import resolves and real types apply. Adds@relayflows/coreas a dependency.@agent-relay/sdk/workflowsto use@relayflows/core.Written for commit 1327d5f. Summary will update on new commits.