Skip to content

fix(workflows): import @relayflows/core instead of the removed sdk subpath - #112

Merged
khaliqgant merged 1 commit into
mainfrom
fix/relayflows-core-import-clean
Aug 17, 2026
Merged

fix(workflows): import @relayflows/core instead of the removed sdk subpath#112
khaliqgant merged 1 commit into
mainfrom
fix/relayflows-core-import-clean

Conversation

@khaliqgant

@khaliqgant khaliqgant commented Aug 17, 2026

Copy link
Copy Markdown
Member

Summary

workflows/linear-chat-lead.ts — our reference workflow — opened with import { workflow } from '@agent-relay/sdk/workflows', which cannot resolve. @agent-relay/sdk exports ., ./messaging, ./delivery, ./actions, ./session, and ./capabilities and has no ./workflows subpath. Verified against published 11.6.10 and monorepo source 11.6.2, which has no packages/sdk/src/workflows directory at all.

cloud/scripts/smoke-sandbox-image.mjs records the replacement:

@relayflows/core present (replaces the removed @agent-relay/sdk/workflows)

Why the stub had to go

workflows/agent-relay-workflows.d.ts existed only to paper over the missing module — a hand-written declare module '@agent-relay/sdk/workflows' with:

type StepOptions = Record<string, unknown>;

So every step in our reference workflow was typed as an untyped bag, and a typo in any step option could not be caught. Deleted in favour of the real types.

Changes

  • workflows/linear-chat-lead.ts: import from @relayflows/core
  • delete workflows/agent-relay-workflows.d.ts
  • add @relayflows/core as a dependency so the reference workflow typechecks against the shipping API rather than a local approximation

Verification

tsc --noEmit -p tsconfig.json exits 0 (workflows/*.ts is in include, so the reference workflow is genuinely covered now).

Companion doc fix: AgentWorkforce/skills — the workflow-authoring skills carried the same stale import.

🤖 Generated with Claude Code


Summary by cubic

Fixes the broken workflow import by switching from the removed @agent-relay/sdk/workflows subpath to @relayflows/core, and removes the local type stub so the reference workflow typechecks against the real API. Previously the import failed and step options were untyped; now the import resolves and real types apply. Adds @relayflows/core as a dependency.

  • Update any other workflows or docs importing @agent-relay/sdk/workflows to use @relayflows/core.

Written for commit 1327d5f. Summary will update on new commits.

Review in cubic

…bpath

linear-chat-lead.ts opened with `import { workflow } from
'@agent-relay/sdk/workflows'`, which cannot resolve: `@agent-relay/sdk` exports
`.`, `./messaging`, `./delivery`, `./actions`, `./session`, and `./capabilities`
and has no `./workflows` subpath. cloud/scripts/smoke-sandbox-image.mjs records
that `@relayflows/core` "replaces the removed @agent-relay/sdk/workflows".

workflows/agent-relay-workflows.d.ts existed only to paper over that: a
hand-written `declare module '@agent-relay/sdk/workflows'` stub with `type
StepOptions = Record<string, unknown>`, which meant every step in our reference
workflow was typed as an untyped bag and typos in step options could not be
caught. Deleted in favour of the real types.

Adds @relayflows/core as a dependency so the reference workflow typechecks
against the shipping API rather than a local approximation.

Verified: `tsc --noEmit -p tsconfig.json` exits 0.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@cursor

cursor Bot commented Aug 17, 2026

Copy link
Copy Markdown

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

@coderabbitai

coderabbitai Bot commented Aug 17, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 7397b2ad-3ee7-4c13-9572-9997d1a8c1b9

📥 Commits

Reviewing files that changed from the base of the PR and between a8215b1 and 1327d5f.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (3)
  • package.json
  • workflows/agent-relay-workflows.d.ts
  • workflows/linear-chat-lead.ts
💤 Files with no reviewable changes (1)
  • workflows/agent-relay-workflows.d.ts

Included review availability: Your plan includes up to 1 review per rolling hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The workflow now uses @relayflows/core. The package declares this dependency. Obsolete @agent-relay/sdk/workflows declarations are removed.

Changes

Relayflows migration

Layer / File(s) Summary
Dependency and workflow import update
package.json, workflows/linear-chat-lead.ts, workflows/agent-relay-workflows.d.ts
The package adds @relayflows/core. The workflow imports from the new module. The obsolete workflow declarations are removed.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to 1327d

This localized dependency and import correction removes a non-resolving module reference and uses the shipping workflow types; no actionable merge-blocking risk remains after normal checks and review.

Suggested reviewers: miyaontherelay

Poem

A rabbit hops through relay code,
A fresh core bears the workflow load.
Old type leaves fade from view,
New imports guide the queue,
And carrots compile in a tidy abode.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: replacing the removed SDK workflow subpath with @relayflows/core.
Description check ✅ Passed The description directly explains the broken import, removed type stub, dependency change, and verification.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/relayflows-core-import-clean

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 4 files

Re-trigger cubic

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1327d5f983

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread package.json
"@relayfile/adapter-daytona": "^0.1.1",
"@relayfile/relay-helpers": "0.4.6"
"@relayfile/relay-helpers": "0.4.6",
"@relayflows/core": "^1.0.6"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Align Relayflows with the pinned Workforce packages

When this dependency is installed, the existing global override in package.json forces @agentworkforce/persona-kit 4.1.23 into every consumer, but the new core package declares ^4.1.39, and its newly introduced @agentworkforce/persona-registry 4.1.43 requires persona-kit exactly 4.1.43 (package-lock.json lines 370-376 and 4294-4305). npm overrides suppress that incompatibility, so a fresh install can succeed while the Linear workflow loads core/registry against a persona-kit older than their declared minimum and may fail on newer APIs at startup. Use a Relayflows version compatible with 4.1.23 or update the Workforce pins and overrides together.

Useful? React with 👍 / 👎.

@khaliqgant
khaliqgant merged commit 83ac077 into main Aug 17, 2026
2 checks passed
@khaliqgant
khaliqgant deleted the fix/relayflows-core-import-clean branch August 17, 2026 13:22
@khaliqgant

Copy link
Copy Markdown
Member Author

Confirmed — this is a real conflict and I'm not merging it as-is.

agents overrides : @agentworkforce/persona-kit 4.1.23
                   (also @agentworkforce/{deploy,local-surface,runtime} 4.1.23)
@relayflows/core : @agentworkforce/persona-kit    ^4.1.39
                   @agentworkforce/persona-registry ^4.1.39

The global override pins persona-kit below @relayflows/core's declared minimum. npm overrides suppress the incompatibility, so a fresh install succeeds while core/registry load against a persona-kit older than they declare — exactly the silent-at-install, loud-at-startup shape you describe.

Neither half of this PR is independently shippable:

  • the import fix is correct and needed — @agent-relay/sdk/workflows cannot resolve at all
  • but the import only typechecks because of the dependency addition, which is what creates the conflict

Proposed split

  1. Bump the Workforce pins and overrides together (4.1.23 → 4.1.43 across deploy, local-surface, persona-kit, runtime) as its own PR. That touches every agent in this repo, so it needs its own verification pass — deploy preflight, the composable-runtime-closure acceptance harness, and a persona compile — not a ride-along on a one-line import fix.
  2. Then land this import fix on top, at which point ^4.1.39 is satisfied honestly rather than by override suppression.

I'd rather leave the stale import in place for now than paper over a dependency conflict with an override; the stale import fails loudly and immediately, whereas this would fail at agent startup.

Companion fixes already merged: AgentWorkforce/relayflows#31–34, AgentWorkforce/relayfile#430, AgentWorkforce/skills#97 (which fixed the same stale specifier in the docs and in workflows/audit-skills-clarity.ts).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant