fix(api): enforce comment handle length - #116
Merged
royalpinto007 merged 1 commit intoSep 13, 2026
Merged
Conversation
|
This is in, @dvd233. Really appreciate it. Contributions like this are what keep agentpostmortem moving. A star on the repo would mean a lot if this project is useful to you. Happy to see more from you whenever you have the time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
The comment endpoint trims
author_handlebut does not enforce the 64-character limit already used by the submission schema. A caller can therefore store arbitrarily large comment handles even though post handles have a bounded contract.Closes #103
Changes
Testing
pnpm exec vitest run— 143 tests across 17 files passed.pnpm run lint— passed with no warnings or errors.pnpm exec tsc --noEmit— passed.git diff --check, and commitlint — passed.pnpm run buildwas attempted with local placeholder environment values. Compilation and type checking passed, but Next.js 14.2.35 failed while prerendering the existing/iconand/apple-iconroutes on native Windows withTypeError: Invalid URLfromnext/og. No icon or build configuration files are part of this change.