fix(api): keep anonymous submitter handles private - #115
Merged
royalpinto007 merged 1 commit intoSep 13, 2026
Merged
royalpinto007 merged 1 commit into
royalpinto007 merged 1 commit into
Conversation
|
Merged. Thanks a lot, @dvd233. agentpostmortem gets better every time someone outside the repo digs in like this. If you find agentpostmortem useful, consider dropping a star. It helps more people find it. Happy to see more from you whenever you have the time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
is_anonymouscontrols whether a submission's author identity is public, but the create and edit routes still persisted a supplied handle when it was set totrue. The public post mapper also returned handles from legacy anonymous rows, so a direct API consumer could recover an identity the submitter intended to hide.Closes #102
Changes
submitter_handleon create and edit wheneveris_anonymousis true.Testing
pnpm exec vitest run— 145 tests across 16 files passed.pnpm run lint— passed with no warnings or errors.pnpm exec tsc --noEmit— passed.git diff --check— passed.pnpm run buildwas attempted with local placeholder environment values. Compilation and type checking passed, but Next.js 14.2.35 failed while prerendering the existing/iconand/apple-iconroutes on native Windows withTypeError: Invalid URLfromnext/og. No icon or build configuration files are part of this change.