fix: recognize Confirmed phrasing as a confirmation - #24
Merged
royalpinto007 merged 1 commit intoSep 16, 2026
Merged
Conversation
The _CONFIRM pattern matched confirm/confirming but not 'Confirmed', so a properly echoed confirmation still flagged no_confirmation. Extend the alternation to confirm(?:ing|ed)? per issue acceptance. Closes AgentPostmortem#12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
ctxlens-style false positive:check_acted_without_confirmingflaggedno_confirmationeven when the agent had replied "Confirmed, refunding $20." The_CONFIRMpattern matchedconfirm/confirmingbut notconfirmed(trailing\bfails beforeed).Change
Extend the alternation to
confirm(?:ing|ed)?so the natural past-tense reply is recognized as a confirmation.Confirmed, ...now suppresses theno_confirmationfinding, matching the issue's acceptance criteria.Tests
Added a failing test first: an agent turn
"Confirmed, refunding $20."before a consequential refund action must not produceno_confirmation. Full suite: 66 passed.Related
Closes #12