Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/tenantq/search.py
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,11 @@ def search(
)
query = str(query).strip()

if not 1 <= limit <= 1000:
raise ValueError(f"limit must be within 1-1000, got {limit!r}")
if not 1 <= prefetch_limit <= 10000:
raise ValueError(f"prefetch_limit must be within 1-10000, got {prefetch_limit!r}")

qfilter = build_filter(tenant_id, category, created_after, created_before)
params = models.SearchParams(hnsw_ef=settings.hnsw.hnsw_ef)

Expand Down
33 changes: 33 additions & 0 deletions tests/test_search.py
Original file line number Diff line number Diff line change
Expand Up @@ -91,3 +91,36 @@ def test_build_filter_allows_wide_open_range():
from tenantq.search import build_filter
f = build_filter("acme", created_after=100, created_before=200)
assert f.must


@pytest.mark.parametrize("limit", [-1, 0, 10_000])
def test_search_rejects_out_of_range_limit(settings, limit):
client = MagicMock()
embedder = MagicMock()
with pytest.raises(ValueError, match="limit must be within"):
search(client, settings, embedder, "dense query", tenant_id="acme", mode="dense", limit=limit)
client.query_points.assert_not_called()


@pytest.mark.parametrize("prefetch_limit", [-1, 0, 10_001])
def test_search_rejects_out_of_range_prefetch_limit(settings, prefetch_limit):
client = MagicMock()
embedder = MagicMock()
with pytest.raises(ValueError, match="prefetch_limit must be within"):
search(
client, settings, embedder, "hybrid query",
tenant_id="acme", mode="hybrid", prefetch_limit=prefetch_limit,
)
client.query_points.assert_not_called()


def test_search_accepts_max_prefetch_limit(settings):
client = MagicMock()
embedder = MagicMock()
client.query_points.return_value.points = []
hits = search(
client, settings, embedder, "hybrid query",
tenant_id="acme", mode="hybrid", prefetch_limit=10_000,
)
assert hits == []
client.query_points.assert_called_once()
Loading