fix: from_env() names the variable in int parse errors - #18
Merged
Merged
Conversation
TENANTQ_HNSW_M=abc crashed startup with a bare ValueError from int() that named nothing. Use a helper that reports which variable was malformed. Closes AgentPostmortem#13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
TENANTQ_HNSW_M=abccrashed startup with a rawValueErrorfromint()that did not say which variable was malformed.Change
Added an
_env_int(name, default)helper that converts for HNSW tuning, payload, and dense-dim vars, raisingValueError(f"{name} must be an integer, got ...")on a bad value.Tests
Added a failing test first: for each of
TENANTQ_HNSW_M,TENANTQ_HNSW_EF,TENANTQ_DENSE_DIMset to"abc",Settings.from_env()must raise with that variable named. Suite: 24 passed.ruff checkclean.Related
Closes #13