fix: validate CLI --mode with a click Choice - #16
Merged
Merged
Conversation
A free-string --mode died deep inside with an unknown-mode traceback. Constrain the option to dense/sparse/hybrid so typos fail fast with a usage error listing the valid modes. Closes AgentPostmortem#14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
CLI
--modewas a free string, so--mode hybirddied deep insidesearch.pywith anunknown modetraceback instead of a usage error listing valid modes.Change
Constrain
--modeto aclick.Choice(["dense", "sparse", "hybrid"]), so a typo fails fast with'hybird' is not one of 'dense', 'sparse', 'hybrid'.(click is already vendored as a typer dependency; the runtime environment is unchanged).Tests
Added
tests/test_cli.pyfirst: parametrized overhybird,HYBRID, anddense, each must exit non-zero with an error that listshybrid. Suite: 24 passed.ruff checkclean.Related
Closes #14