fix: handle invalid regex in rubric criteria without crashing - #48
Merged
royalpinto007 merged 1 commit intoSep 12, 2026
Merged
royalpinto007 merged 1 commit into
royalpinto007 merged 1 commit into
Conversation
Catch invalid RegExp patterns in rubric criteria instead of throwing, matching regex and json-schema scorer behavior. Fixes AgentPostmortem#33
|
Merged, @sharadvc. Thank you for taking the time. Contributions like this are what keep Evalgate moving. A star on the repo would mean a lot if this project is useful to you. Happy to see more from you whenever you have the time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Invalid
patternregexes in rubric criteria now return a fail result with a clear reason instead of throwingSyntaxErrorand stopping the run.Test plan
npm testFixes #33