fix: reject negative or NaN compareRuns tolerance - #42
Merged
royalpinto007 merged 1 commit intoSep 12, 2026
Merged
royalpinto007 merged 1 commit into
royalpinto007 merged 1 commit into
Conversation
Validate tolerance is a non-negative finite number before comparing runs. Negative tolerance could mark improvements as regressions; NaN disabled regression detection entirely. Co-authored-by: Sharad. <sharadvc@users.noreply.github.com>
|
Nice work @sharadvc, this is merged. Good, focused change. Exactly the kind of thing Evalgate needs. If Evalgate is useful to you, a star goes a long way. Happy to see more from you whenever you have the time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
compareRunsnow rejects non-finite or negativetolerancevalues withCompareValidationErrorinstead of accepting them.Test plan
npm test— includes negative and NaN tolerance casesFixes #30