fix: surface unreadable files as estimated tokens instead of 0 - #39
Merged
royalpinto007 merged 2 commits intoSep 18, 2026
Merged
Conversation
sharadvc
force-pushed
the
fix/surface-unreadable-files
branch
from
September 17, 2026 02:50
d8dbe24 to
70a1b2f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Closes #11. An unreadable file (e.g. EACCES / mode-000) was silently reported as a clean 0-token source because
readFileSyncthrows and the catch returned{ tokens: 0, sample: "" }. That hid real content from classification and totals. Now a 200 KB unreadable file is estimated from its known size (size/4) and flows through classification (→ "large" → trim) instead of reading as clean.Checklist
node --test) — 18 passed / 0 failedsrc/scan.js(read-catch returns estimated tokens) + regression testCHANGELOG.mdentryNotes
Test-first: the new test failed (
got 0) before the fix, then passed. CI smoke (node bin/ctxtrim.js test/fixtures/sample-repo --format json) OK. Authored with AI assistance; change reviewed and verified locally (commit c1b9860, matches prior teammate report).