fix(cli): reject out-of-range numeric options with exit code 2 - #21
Merged
royalpinto007 merged 2 commits intoSep 18, 2026
Merged
Conversation
--top, --tool-result-cap, --tool-def-budget and --fail-over-ratio accepted negative, NaN and out-of-range values and produced garbage output. Add validation callbacks so invalid values exit with code 2 and a clear message instead of silently mis-running. Closes AgentPostmortem#8
sharadvc
force-pushed
the
fix/cli-numeric-validation
branch
from
September 17, 2026 03:01
73f8584 to
c9bbb16
Compare
Member
|
Production code is correct (exit 2 fires). Only the new test is at fault: with color enabled (as in CI) Rich highlights the flag as ANSI fragments, so literal --top never appears contiguously. Please strip ANSI codes (re.sub(r'\x1b[[0-9;]*m', '', result.stderr)) before asserting the flag name. |
Rich 15 renders the error panel with ANSI styling, splitting flag names (e.g. '--top' becomes '-[esc]-top'), so substring-matching the option flag in stderr is unreliable. Assert on the plain-text reason message from the callback instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Closes #8. CLI numeric options (e.g.
--top,--limit,--tail) accepted negative, NaN, and out-of-range values, producing garbage reports or silent truncation.Changes
src/ctxlens/cli.py: validate numeric option values up front; reject invalid ranges with a clean error and exit code 2.tests/test_cli.py: regression cases for negative / NaN / out-of-range values.Checklist
Authored with AI assistance; rebased onto current main, tests re-run.