Conversation
- `retrofit.create(Service::class.java)` 형식을 Kotlin 확장 함수인 `retrofit.create<Service>()`로 변경 - `AfternoteServiceModule`, `MindRecordServiceModule`, `TimeLetterModule`, `ServiceModule` 내 모든 API 서비스 정의 수정 - 불필요한 `.java` 클래스 참조를 제거하여 코드의 간결성 및 가독성 개선
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌𝘐𝘴𝘴𝘶𝘦𝘴
Closes #378 â�� refactor: Retrofit ServiceModule을 reified create()로 통일
📎𝘞𝘰𝘳𝘬 𝘋𝘦𝘴𝘤𝘳𝘪𝘱𝘵𝘪𝘰𝘯
retrofit.create(Xxx::class.java)→retrofit.create<Xxx>()통일 (15곳, dedeecc)core/network: 5 (Auth/Token/Account/User/Image)feature/afternote/data: 4 (Afternote/Music/ReceiverAfternote/ReceiverAuth)feature/mindrecord/data: 5 (DailyQuestion/Diary/DeepThought/MindRecordReceiver/WeeklyReport)feature/timeletter/data: 1 (TimeLetter)import retrofit2.create추가📷𝘚𝘤𝘳𝘦𝘦𝘯𝘴𝘩𝘰𝘵
UI 변경 없음 — DI 표기 리팩터링.
💬𝘛𝘰 𝘙𝘦𝘷𝘪𝘦𝘸𝘦𝘳𝘴
create(T::class.java)를 호출 — 런타임 동작·성능 동일, 표기만 간결retrofit = 3.0.0이라 그대로 사용afternote의provideReceiverAfternoteApiService는 reified 로 짧아져 멀티라인→한 줄(ktlint function-signature).mindrecord동일 케이스는 한 줄이 max 초과라 멀티라인 유지:core:network+:feature:{afternote,mindrecord,timeletter}:data의 compileDebugKotlin + ktlintMainSourceSetCheck BUILD SUCCESSFUL