Conversation
- 기본 Material Icons(`Search`, `PlayArrow`, `Person`, `Settings`)를 대체할 커스텀 벡터 드로어블 리소스 추가 - `SearchableSongList`, `MemorialReceivedDetailScreen`, `TopHeader` 컴포저블에서 `Icons.Default` 대신 `painterResource`를 사용하도록 수정 - `core:ui` 및 `afternote:presentation` 모듈의 `build.gradle.kts`와 `libs.versions.toml`에서 미사용되는 `material-icons-core` 의존성 삭제 - `MainActivity`에서 `enableEdgeToEdge()` 호출 위치를 `onCreate` 상단으로 이동하여 엣지 투 엣지 설정 시점 최적화
- 프로젝트 내 정적 분석 도구 설정을 담은 `config/detekt/detekt.yml` 파일 제거 - `@Composable` 함수의 네이밍 규칙(PascalCase) 예외 처리 및 `@Preview` 관련 미사용 멤버 검사 제외 설정 삭제
|
❌ Screenshot test fail — baseline 과 CI rendered PNG 차이. 📦 Artifact: https://github.com/Afternote/Afternote-FE/actions/runs/26859022602 (페이지 하단 Artifacts → 🔍 확인 위치 (artifact zip 내부):
📝 조치 가이드:
CI ↔ 로컬 환경 차이는 본 워크플로의 container 단계가 root fix 한다 (README 의 "Compose Preview Screenshot Testing (docker baseline)" 섹션 참조). |
- `MemorialPlaylistScreenScreenshotTest`의 검증용 레퍼런스 스크린샷 이미지 갱신
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌𝘐𝘴𝘴𝘶𝘦𝘴
closed refactor: Material Icons 제거 및 Material Symbols vector drawable 전환 #382
📎𝘞𝘰𝘳𝘬 𝘋𝘦𝘴𝘤𝘳𝘪𝘱𝘵𝘪𝘰𝘯
material-icons-extended의존성 제거 —core:ui,feature:afternote:presentation,gradle/libs.versions.toml(abc3a3b)ic_person,ic_play_arrow,ic_search,ic_settingsMainActivity,MemorialReceivedDetailScreen,TopHeader,SearchableSongList—Icons.Default.*imageVector →painterResource(...)config/detekt/detekt.yml삭제 (526ac12)📷𝘚𝘤𝘳𝘦𝘦𝘯𝘴𝘩𝘰𝘵
아이콘을 동등한 Material Symbols 벡터 drawable 로 1:1 교체 — 시각 변화 없음
💬𝘛𝘰 𝘙𝘦𝘷𝘪𝘦𝘸𝘦𝘳𝘴
./gradlew :feature:afternote:presentation:compileDebugKotlin :app:compileDebugKotlinBUILD SUCCESSFULdetekt.yml삭제는 동일 브랜치 부수 정리 — 현재 빌드 파이프라인에서 미사용 설정 파일