Repository navigation
Conversation
…nnect On networks that resolve AAAA records but have no working IPv6 route, public_connection gave the first (IPv6) address the whole 15 s budget, so the token exchange timed out without ever trying IPv4. The resulting TimeoutError escaped handle_callback after the PKCE state was consumed, leaving a null authorization result (UI reported a timeout) and any browser retry of the callback failed with state_mismatch. - interleave address families and cap each connect attempt at 3 s, still within the shared deadline - end the authorization attempt as an error on any token exchange failure and log it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spotify connect now works on networks where IPv6 resolves but has no route.
Each address gets 3 s, so a dead IPv6 address no longer blocks IPv4.
A failed token exchange now shows an error instead of a timeout and state_mismatch.
Blast radius: all outbound provider calls (Spotify, catalogue lookups) for users with slow IPv6 or IPv4 connects.