Skip to content

chore: improve CI tooling, linting, and code cleanup#2

Merged
Aderinom merged 12 commits into
mainfrom
chore/cleanup
Jun 27, 2026
Merged

chore: improve CI tooling, linting, and code cleanup#2
Aderinom merged 12 commits into
mainfrom
chore/cleanup

Conversation

@Aderinom

Copy link
Copy Markdown
Owner

License Change:

  • The project is now dual-licensed under MIT or Apache-2.0, allowing users to choose either license for their use of the code.
  • Contributors are required to agree to the dual licensing terms, ensuring that contributions are compatible with both licenses.

Changes:

  • Added GitHub Actions CI workflow for formatting, linting, testing, documentation, and license checks.
  • Added check.sh script to run common cargo commands in parallel with summaries and fix mode.
  • Added .vscode/tasks.json for background cargo clippy task.
  • Added .vscode/settings.json for nightly rustfmt and custom spellcheck words
  • Added .rustfmt.toml for consistent Rust code formatting.
  • Updated Cargo.toml workspace settings for license, edition, version, and Clippy lints.
  • Added deny.toml to configure cargo-deny for license and dependency checks
  • Updated readme.md and cleaned up root
  • Enabled pedantic and nursery Clippy lints in Cargo.toml .
  • Fixed any linting issues and formatting inconsistencies in the codebase.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR modernizes the Wrapp Rust workspace by centralizing workspace metadata/lints, adding developer/CI tooling, and updating repository documentation/licensing to support ongoing development with consistent checks.

Changes:

  • Introduces dual licensing (MIT OR Apache-2.0) and adds cargo-deny policy configuration.
  • Adds/updates tooling for automated checks (GitHub Actions CI, check.sh, pinned toolchain, rustfmt/clippy workspace lints).
  • Cleans up and restructures documentation (new README structure and docs/idea.md, removes obsolete ideas.md).

Reviewed changes

Copilot reviewed 41 out of 43 changed files in this pull request and generated 11 comments.

Show a summary per file
File Description
.github/workflows/ci.yml Adds CI workflow to run formatting/lint/test/doc/deny checks (currently has YAML issues to fix).
.gitignore Stops ignoring Cargo.lock and ignores a local tooling directory.
.rustfmt.toml Adds rustfmt configuration (notes nightly requirement).
.vscode/settings.json Adds editor settings for rustfmt and spellcheck (currently invalid JSON due to trailing comma).
.vscode/tasks.json Adds a background clippy watch task for VS Code.
Cargo.lock Updates lockfile to reflect workspace dependency graph changes.
Cargo.toml Sets workspace-wide license/edition/version and workspace clippy lint levels.
LICENSE-APACHE Adds Apache-2.0 license text for dual-licensing.
LICENSE-MIT Adds MIT license text for dual-licensing.
check.sh Adds a helper script to run common cargo checks (parallelized for “check”, sequential for “fix”).
deny.toml Adds cargo-deny configuration for license/advisory/source policies (has a comment that should reflect dual-licensing).
docs/idea.md Adds design rationale document (moved from older notes).
docs/todo Updates roadmap checkboxes (marks config items complete).
examples/prototype/Cargo.toml Moves package metadata to workspace and enables workspace lints for the prototype crate.
features/wrapp-config/Cargo.toml Uses workspace version/edition/license and enables workspace lints.
features/wrapp-config/examples/using-config-provider.rs Refactors example to use let-else for readability.
features/wrapp-config/src/errors.rs Small cleanup/formatting.
features/wrapp-config/src/lib.rs Doc/formatting cleanup and module ordering tweak.
features/wrapp-config/src/provider.rs Improves readability and adds docs/must_use on constructors.
features/wrapp-config/src/resolver.rs Adds #[must_use] and small refactors for clarity.
features/wrapp-di/Cargo.toml Uses workspace version/edition/license and enables workspace lints.
features/wrapp-di/examples/manual-di-impl.rs Improves example documentation and naming.
features/wrapp-di/src/builder.rs Adds richer docs and #[must_use] on builder methods.
features/wrapp-di/src/container.rs Improves docs and small refactors around error mapping.
features/wrapp-di/src/dependency_graph.rs Adds error/docs improvements and minor formatting changes.
features/wrapp-di/src/errors.rs Removes a generic Other error variant.
features/wrapp-di/src/factories.rs Renames dependency method and tightens trait bounds/refactors mapping.
features/wrapp-di/src/initiator.rs Refactors for readability and improves docs/comments.
features/wrapp-di/src/lib.rs Updates crate-level docs (still contains some incorrect identifiers/typos).
features/wrapp-di/src/resolver/arc.rs Refactors match arms for readability.
features/wrapp-di/src/resolver/lazy.rs Improves docs/must_use annotations and refactors for clarity.
features/wrapp-di/src/types.rs Refactors constructors and adds docs/must_use.
features/wrapp-router/Cargo.toml Uses workspace version/edition/license and enables workspace lints.
features/wrapp-router/src/lib.rs Marks add as #[must_use] and const fn.
features/wrapp-strategies/Cargo.toml Uses workspace version/edition/license and enables workspace lints.
features/wrapp-strategies/src/lib.rs Marks add as #[must_use] and const fn.
ideas.md Removes obsolete notes file (content moved to docs/idea.md).
readme.md Rewrites README structure/content and adds licensing/contributing notes (contains some spelling typos to fix).
rust-toolchain.toml Pins Rust toolchain and components (currently mismatched with nightly rustfmt requirement).
strategies/wrapp-actix/Cargo.toml Uses workspace version/edition/license and enables workspace lints.
strategies/wrapp-actix/src/lib.rs Marks add as #[must_use] and const fn.
wrapp/Cargo.toml Uses workspace version/edition/license and enables workspace lints.
wrapp/src/lib.rs Marks add as #[must_use] and const fn.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/ci.yml
Comment thread .github/workflows/ci.yml
Comment thread .vscode/settings.json
Comment thread readme.md Outdated
Comment thread readme.md Outdated
Comment thread features/wrapp-di/src/builder.rs Outdated
Comment thread features/wrapp-di/src/initiator.rs Outdated
Comment thread deny.toml Outdated
Comment thread rust-toolchain.toml Outdated
Comment thread features/wrapp-di/src/lib.rs Outdated

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 43 out of 45 changed files in this pull request and generated 11 comments.

Comment thread features/wrapp-di/src/initiator.rs
Comment thread examples/prototype/Cargo.toml
Comment thread rust-toolchain.toml Outdated
Comment thread readme.md Outdated
Comment thread readme.md Outdated
Comment thread features/wrapp-di/src/lib.rs
Comment thread features/wrapp-di/src/lib.rs Outdated
Comment thread docs/idea.md
Comment thread docs/idea.md
Comment thread docs/idea.md
@Aderinom
Aderinom merged commit 8910064 into main Jun 27, 2026
1 check passed
@Aderinom
Aderinom deleted the chore/cleanup branch June 27, 2026 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants