chore: improve CI tooling, linting, and code cleanup#2
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR modernizes the Wrapp Rust workspace by centralizing workspace metadata/lints, adding developer/CI tooling, and updating repository documentation/licensing to support ongoing development with consistent checks.
Changes:
- Introduces dual licensing (MIT OR Apache-2.0) and adds
cargo-denypolicy configuration. - Adds/updates tooling for automated checks (GitHub Actions CI,
check.sh, pinned toolchain, rustfmt/clippy workspace lints). - Cleans up and restructures documentation (new README structure and
docs/idea.md, removes obsoleteideas.md).
Reviewed changes
Copilot reviewed 41 out of 43 changed files in this pull request and generated 11 comments.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/ci.yml |
Adds CI workflow to run formatting/lint/test/doc/deny checks (currently has YAML issues to fix). |
.gitignore |
Stops ignoring Cargo.lock and ignores a local tooling directory. |
.rustfmt.toml |
Adds rustfmt configuration (notes nightly requirement). |
.vscode/settings.json |
Adds editor settings for rustfmt and spellcheck (currently invalid JSON due to trailing comma). |
.vscode/tasks.json |
Adds a background clippy watch task for VS Code. |
Cargo.lock |
Updates lockfile to reflect workspace dependency graph changes. |
Cargo.toml |
Sets workspace-wide license/edition/version and workspace clippy lint levels. |
LICENSE-APACHE |
Adds Apache-2.0 license text for dual-licensing. |
LICENSE-MIT |
Adds MIT license text for dual-licensing. |
check.sh |
Adds a helper script to run common cargo checks (parallelized for “check”, sequential for “fix”). |
deny.toml |
Adds cargo-deny configuration for license/advisory/source policies (has a comment that should reflect dual-licensing). |
docs/idea.md |
Adds design rationale document (moved from older notes). |
docs/todo |
Updates roadmap checkboxes (marks config items complete). |
examples/prototype/Cargo.toml |
Moves package metadata to workspace and enables workspace lints for the prototype crate. |
features/wrapp-config/Cargo.toml |
Uses workspace version/edition/license and enables workspace lints. |
features/wrapp-config/examples/using-config-provider.rs |
Refactors example to use let-else for readability. |
features/wrapp-config/src/errors.rs |
Small cleanup/formatting. |
features/wrapp-config/src/lib.rs |
Doc/formatting cleanup and module ordering tweak. |
features/wrapp-config/src/provider.rs |
Improves readability and adds docs/must_use on constructors. |
features/wrapp-config/src/resolver.rs |
Adds #[must_use] and small refactors for clarity. |
features/wrapp-di/Cargo.toml |
Uses workspace version/edition/license and enables workspace lints. |
features/wrapp-di/examples/manual-di-impl.rs |
Improves example documentation and naming. |
features/wrapp-di/src/builder.rs |
Adds richer docs and #[must_use] on builder methods. |
features/wrapp-di/src/container.rs |
Improves docs and small refactors around error mapping. |
features/wrapp-di/src/dependency_graph.rs |
Adds error/docs improvements and minor formatting changes. |
features/wrapp-di/src/errors.rs |
Removes a generic Other error variant. |
features/wrapp-di/src/factories.rs |
Renames dependency method and tightens trait bounds/refactors mapping. |
features/wrapp-di/src/initiator.rs |
Refactors for readability and improves docs/comments. |
features/wrapp-di/src/lib.rs |
Updates crate-level docs (still contains some incorrect identifiers/typos). |
features/wrapp-di/src/resolver/arc.rs |
Refactors match arms for readability. |
features/wrapp-di/src/resolver/lazy.rs |
Improves docs/must_use annotations and refactors for clarity. |
features/wrapp-di/src/types.rs |
Refactors constructors and adds docs/must_use. |
features/wrapp-router/Cargo.toml |
Uses workspace version/edition/license and enables workspace lints. |
features/wrapp-router/src/lib.rs |
Marks add as #[must_use] and const fn. |
features/wrapp-strategies/Cargo.toml |
Uses workspace version/edition/license and enables workspace lints. |
features/wrapp-strategies/src/lib.rs |
Marks add as #[must_use] and const fn. |
ideas.md |
Removes obsolete notes file (content moved to docs/idea.md). |
readme.md |
Rewrites README structure/content and adds licensing/contributing notes (contains some spelling typos to fix). |
rust-toolchain.toml |
Pins Rust toolchain and components (currently mismatched with nightly rustfmt requirement). |
strategies/wrapp-actix/Cargo.toml |
Uses workspace version/edition/license and enables workspace lints. |
strategies/wrapp-actix/src/lib.rs |
Marks add as #[must_use] and const fn. |
wrapp/Cargo.toml |
Uses workspace version/edition/license and enables workspace lints. |
wrapp/src/lib.rs |
Marks add as #[must_use] and const fn. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
License Change:
Changes:
check.shscript to run common cargo commands in parallel with summaries and fix mode..vscode/tasks.jsonfor backgroundcargo clippytask..vscode/settings.jsonfor nightlyrustfmtand custom spellcheck words.rustfmt.tomlfor consistent Rust code formatting.Cargo.tomlworkspace settings for license, edition, version, and Clippy lints.deny.tomlto configurecargo-denyfor license and dependency checksreadme.mdand cleaned up rootpedanticandnurseryClippy lints inCargo.toml.