fix: post array removal equipment and role issues

[OH296]

---

Summary by cubic

Replaces legacy role/equipment and livery flows with structured popups in creation. Fixes name blocking and makes equipment selection consistent across creation and re‑equip.

• Bug Fixes

  • Role name input now uses TextBarArea with tooltips, case‑insensitive blocked values, and “allowed” checks so invalid names never overwrite; prevents stuck blocked states.
  • Creation equipment popup uses shared draw_popup_equip with before/after view off, quality changes off, and from_inventory off; sets recipient type (Marine vs. Dreadnought) and writes role data via array↔struct conversion.
  • reload_items respects from_inventory; UnitEquipment ignores unknown keys, counts inventory only when needed, enforces Dreadnought/experience rules, and avoids invalid slot checks.
  • Livery picking preserves starting colours, updates complex livery data, and shows role names from player_role_data.

• Refactors

  • Centralized eEQUIPMENT_SLOT in scripts/enums/enums.gml; removed duplicate enum.
  • Added setup_UI_elements_equipment_selector(x,y) and made draw_popup_equip(before_after_styling) reusable for both re‑equip and creation.
  • Added convert_equipment_struct_into_array; used for role editing and UI. add_unit_to_company now merges role defaults with overrides before alter_equipment.
  • Popups created via instance_create_depth with typed data; added ePOPUP_TYPE.LIVERYPICK; role selection opens EQUIP popup; advisor/distribution UI split into scr_distribution_and_advisor_setup.

^{Written for commit f62e5cd. Summary will update on new commits.}

[cubic-dev-ai]

All reported issues were addressed across 12 files

<sub>Tip: cubic used a learning from your PR history. Let your coding agent read cubic learnings directly with the cubic MCP.

Re-trigger cubic</sub>

[cubic-dev-ai]

0 issues found across 3 files (changes from recent commits).

Confidence score: 5/5

• Automated review surfaced no issues in the provided summaries.
• No files require special attention.

<sub>Requires human review: Auto-approval blocked by 7 unresolved issues from previous reviews.

Re-trigger cubic</sub>

[cubic-dev-ai]

All reported issues were addressed across 5 files (changes from recent commits).

<sub>Tip: Review your code locally with the cubic CLI to iterate faster.

Re-trigger cubic</sub>

[cubic-dev-ai]

All reported issues were addressed across 1 file (changes from recent commits).

<sub>Tip: Review your code locally with the cubic CLI to iterate faster.

Re-trigger cubic</sub>