Conversation
u64 and u16 psubtract returned Element(*self) when nothing was subtracted. Nodes propagate identity masks, so subtract_into reported Element for an unchanged trie. The Lean model's u64Ops follows. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019R2H8fnco29asY2v3TPbtF
Collaborator
|
@imlvts What is there a reason behind this change? If there is an expedient reason to change the behavior then it's fine. My issue is that the policies implemented in the Lattice trait implementations on primitives are basically nonsense. Or at least unjustified. The plan is to clean them up with well-behaved policies implemented via ZST policy objects. I have a plan for how to go about that. But any kind of near-term tweak to the policy gives the impression of a well reasoned design, and creates inertia to the current behavior. Encoding anything about the current Lattice impls in the lean model disturbs me greatly. But again, if you have a pragmatic reason then we can merge this PR, as-is. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
u64 and u16 psubtract returned Element(*self) when nothing was subtracted. Nodes propagate identity masks, so subtract_into reported Element for an unchanged trie. The Lean model's u64Ops follows.