Fix remove_unmasked_branches at a dangling path - #112
Merged
luketpeterson merged 3 commits intoSep 19, 2026
Merged
Conversation
A dangling path is a link to the empty node, which get_child_mut won't return, so the zipper passed the stub's own key to the parent node as a branch and tripped a LineListNode debug assert. There is nothing below a dangling path to filter, so do nothing. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019R2H8fnco29asY2v3TPbtF
# Conflicts: # src/write_zipper.rs
… what was in the PR.
Collaborator
|
Simplified the fix a lot. I honestly don't know what the clanker was thinking with this fix. Like a 20 line preflight block instead of adding one extra check (that was part of the 20 line block). Anyway, simplified the fix. Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A dangling path is a link to the empty node, which
get_child_mutwon't return, so the zipper passed the stub's own key to the parent node as a branch and tripped a LineListNode debug assert. There is nothing below a dangling path to filter, so do nothing.