Fix cockpit-server build: import ThinkingStyle from its canonical module#105
Conversation
…eploy build) The cockpit-server release build (Railway) failed: error[E0432]: unresolved import `lance_graph_planner::api::ThinkingStyle` lance-graph moved `ThinkingStyle` behind an `api` re-export that POSTDATES the lance-graph rev this repo pins, so importing it from `lance_graph_planner::api` no longer resolves against the pinned dependency. The enum itself has always lived at `lance_graph_planner::thinking::style::ThinkingStyle` (pub mod thinking → pub mod style), which resolves against every lance-graph version — the compiler's own suggestion. Import ThinkingStyle from that canonical path in the two `planner`-gated call sites (diagnostics.rs, lib.rs); Planner/PlanResult still come from `api`. No behaviour change — same type, robust import path. Unblocks the cockpit-server deploy (and any q2 build against the pinned lance-graph). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012jEwwaT5JZ5x8qWvcnaMYC
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_ae87fab7-8c22-49df-9abe-ac87d2badc37) |
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughPlanner-gated imports in the notebook-query stub now resolve ChangesPlanner import paths
Estimated code review effort: 1 (Trivial) | ~3 minutes Suggested reviewers: Poem
✨ Finishing Touches📝 Generate docstrings
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
mainis currently broken — the cockpit-server release build fails:Cause: cross-repo drift.
lance-graphadded anapire-export ofThinkingStyleafter the lance-graph rev this repo pins, solance_graph_planner::api::ThinkingStyleno longer resolves against the pinned dependency. (This fix was pushed to #104's branch after it merged green, so it stranded — hence a fresh PR offmain.)Fix: import
ThinkingStylefrom its canonical modulelance_graph_planner::thinking::style— where the enum is actually defined (pub mod thinking→pub mod style), public in every lance-graph version. The compiler itself suggests this path.Planner/PlanResultstill come fromapi. Same type, no behavior change.Two
planner-gated call sites incrates/stubs/notebook-query(lib.rs,diagnostics.rs).Verification
cargo check -p notebook-query --features planner→ Finished clean (local, 6m18s).pub mod thinking→pub mod style).🤖 Generated with Claude Code
Generated by Claude Code
Summary by CodeRabbit