fix(ci): avoid secrets in step conditions - #236
Merged
ErikBjare merged 1 commit intoAug 3, 2026
Merged
Conversation
Greptile SummaryThis PR restores workflow parsing by deriving signing-key availability at job scope.
Confidence Score: 5/5The PR appears safe to merge, with no changed-code-triggered defects identified. The derived environment value preserves the signing-key presence semantics while avoiding the invalid direct use of the secrets context in step conditions. Important Files Changed
Reviews (1): Last reviewed commit: "fix(ci): avoid secrets in step condition..." | Re-trigger Greptile |
Contributor
Author
|
CI-green and mergeable (Greptile 5/5) — waiting only on a maintainer click. This PR is ready to merge, but the bot has pull-only access to this repo and can't self-merge — surfacing it here so it isn't lost. The monitoring loop will stop re-flagging it now that this note is posted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
env, where thesecretscontext is validincludeUpdaterJsonin the release workflowRoot cause
#235 introduced
secrets.TAURI_SIGNING_PRIVATE_KEYdirectly in step-levelif:expressions. GitHub rejects that context while parsing a workflow, so both Build and Release failed immediately with zero jobs and no logs onmaster.Verification
actionlint -shellcheck='' .github/workflows/build.yml .github/workflows/release.ymlgit diff --check