Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -84,10 +84,25 @@ jobs:
Expand-Archive -Path $wixZip -DestinationPath $wixDir -Force
Write-Host "WiX installed to $wixDir ($(Get-ChildItem $wixDir | Measure-Object | Select-Object -Expand Count) files)"

- name: Configure updater artifacts
if: ${{ secrets.TAURI_SIGNING_PRIVATE_KEY != '' }}
shell: bash
run: |
python3 - <<'PY'
import json
from pathlib import Path
path = Path("src-tauri/tauri.conf.json")
config = json.loads(path.read_text())
config["bundle"]["createUpdaterArtifacts"] = True
path.write_text(json.dumps(config, indent=2) + "\n")
PY

- name: Build the app
uses: tauri-apps/tauri-action@v0
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
TAURI_SIGNING_PRIVATE_KEY: ${{ secrets.TAURI_SIGNING_PRIVATE_KEY }}
TAURI_SIGNING_PRIVATE_KEY_PASSWORD: ${{ secrets.TAURI_SIGNING_PRIVATE_KEY_PASSWORD }}
with:
args: ${{ matrix.args }}

Expand Down
16 changes: 16 additions & 0 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -80,15 +80,31 @@ jobs:
if: matrix.args != null
run: rustup target add $(echo "${{ matrix.args }}" | cut -d' ' -f2)

- name: Configure updater artifacts
if: ${{ secrets.TAURI_SIGNING_PRIVATE_KEY != '' }}
shell: bash
run: |
python3 - <<'PY'
import json
from pathlib import Path
path = Path("src-tauri/tauri.conf.json")
config = json.loads(path.read_text())
config["bundle"]["createUpdaterArtifacts"] = True
path.write_text(json.dumps(config, indent=2) + "\n")
PY

- name: Build the app
uses: tauri-apps/tauri-action@v0

env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
TAURI_SIGNING_PRIVATE_KEY: ${{ secrets.TAURI_SIGNING_PRIVATE_KEY }}
TAURI_SIGNING_PRIVATE_KEY_PASSWORD: ${{ secrets.TAURI_SIGNING_PRIVATE_KEY_PASSWORD }}
with:
Comment on lines 99 to 103

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Signing-key password is missing

When a password-protected updater key is configured, the workflow enables updater artifacts but forwards only TAURI_SIGNING_PRIVATE_KEY, causing both release and regular build jobs to fail while unlocking the key instead of producing signed updater artifacts.

tagName: ${{ github.ref_name }} # This only works if your workflow triggers on new tags.
releaseName: 'aw-tauri v__VERSION__' # tauri-action replaces \_\_VERSION\_\_ with the app version.
releaseBody: 'See the assets to download and install this version.'
releaseDraft: true
prerelease: false
includeUpdaterJson: ${{ secrets.TAURI_SIGNING_PRIVATE_KEY != '' }}
args: ${{ matrix.args }}
3 changes: 3 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,9 @@ dist-ssr
*.sln
*.sw?

# local dev env
.envrc

# generated files
src-tauri/icons/*
/target/
Loading