Skip to content

ci(release): export VERSION_NO_V so the aw-server-rust version check sees the tag - #1403

Merged
ErikBjare merged 1 commit into
ActivityWatch:masterfrom
TimeToBuildBob:fix/release-export-version-no-v
Aug 20, 2026
Merged

ci(release): export VERSION_NO_V so the aw-server-rust version check sees the tag#1403
ErikBjare merged 1 commit into
ActivityWatch:masterfrom
TimeToBuildBob:fix/release-export-version-no-v

Conversation

@TimeToBuildBob

Copy link
Copy Markdown
Contributor

Fixes #1402.

The v0.14.0b4 release run failed at Verify aw-server-rust submodule version matches release tag:

AW release tag:        (major.minor: )
Bundled aw-server:    0.14.0 (major.minor: 0.14)
ERROR: aw-server-rust major.minor (0.14) does not match AW release major.minor ().

The submodule is fine. The Determine and output version step computes VERSION_NO_V but only writes VERSION_WITH_V to $GITHUB_ENV, so the check (added in #1391) always compared against an empty string — every tagged release has failed this step since.

Changes (both the Qt and Tauri jobs):

  • export VERSION_NO_V to $GITHUB_ENV
  • fail with an explicit "VERSION_NO_V is empty" message if it ever regresses, instead of the misleading "submodule is stale" error

Re-tagging v0.14.0b4 (or tagging b5) after merge should get past this step.

https://claude.ai/code/session_011VKFZeMpLvtZ3e15S1fKUW

…sees the tag

The 'Determine and output version' step computed VERSION_NO_V but only
exported VERSION_WITH_V to GITHUB_ENV, so the submodule-version check added
in ActivityWatch#1391 compared against an empty string and failed every tagged release
(v0.14.0b4: 'AW release major.minor ()').

Export VERSION_NO_V in both the Qt and Tauri jobs, and make the check fail
with an explicit message if the variable is empty instead of blaming the
submodule.

Fixes ActivityWatch#1402
@greptile-apps

greptile-apps Bot commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR fixes the Qt and Tauri tagged-release jobs by exporting the already-computed VERSION_NO_V value for subsequent workflow steps.

  • Exports VERSION_NO_V through GITHUB_ENV in both build jobs.
  • Adds explicit fail-fast diagnostics if the version is unexpectedly empty before validating the bundled Rust server version.

Confidence Score: 5/5

The PR appears safe to merge, with no actionable defects identified in the changed release workflow.

Both build jobs now export the normalized version consumed by their tag-only server-version checks, and their new empty-value guards fail clearly without disrupting valid tag or research-tag versions.

Important Files Changed

Filename Overview
.github/workflows/release.yml Correctly propagates the normalized release version between steps and adds equivalent defensive checks to both release build variants.

Reviews (1): Last reviewed commit: "ci(release): export VERSION_NO_V so the ..." | Re-trigger Greptile

@TimeToBuildBob

Copy link
Copy Markdown
Contributor Author

Greptile is 5/5 and the first Release matrix job has passed; the remaining matrix jobs are still running. No code or review follow-up needed yet — waiting for CI and maintainer review/merge.

@ErikBjare
ErikBjare merged commit 8f99807 into ActivityWatch:master Aug 20, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Failing CI on release

2 participants