ci(release): export VERSION_NO_V so the aw-server-rust version check sees the tag - #1403
Merged
ErikBjare merged 1 commit intoAug 20, 2026
Conversation
…sees the tag The 'Determine and output version' step computed VERSION_NO_V but only exported VERSION_WITH_V to GITHUB_ENV, so the submodule-version check added in ActivityWatch#1391 compared against an empty string and failed every tagged release (v0.14.0b4: 'AW release major.minor ()'). Export VERSION_NO_V in both the Qt and Tauri jobs, and make the check fail with an explicit message if the variable is empty instead of blaming the submodule. Fixes ActivityWatch#1402
Contributor
Greptile SummaryThis PR fixes the Qt and Tauri tagged-release jobs by exporting the already-computed
Confidence Score: 5/5The PR appears safe to merge, with no actionable defects identified in the changed release workflow. Both build jobs now export the normalized version consumed by their tag-only server-version checks, and their new empty-value guards fail clearly without disrupting valid tag or research-tag versions. Important Files Changed
Reviews (1): Last reviewed commit: "ci(release): export VERSION_NO_V so the ..." | Re-trigger Greptile |
Contributor
Author
|
Greptile is 5/5 and the first Release matrix job has passed; the remaining matrix jobs are still running. No code or review follow-up needed yet — waiting for CI and maintainer review/merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1402.
The
v0.14.0b4release run failed at Verify aw-server-rust submodule version matches release tag:The submodule is fine. The Determine and output version step computes
VERSION_NO_Vbut only writesVERSION_WITH_Vto$GITHUB_ENV, so the check (added in #1391) always compared against an empty string — every tagged release has failed this step since.Changes (both the Qt and Tauri jobs):
VERSION_NO_Vto$GITHUB_ENVRe-tagging
v0.14.0b4(or tagging b5) after merge should get past this step.https://claude.ai/code/session_011VKFZeMpLvtZ3e15S1fKUW