Skip to content

Run typecheck, tests, and build on pull requests - #12

Merged
nimble-turtle merged 1 commit into
mainfrom
ci/pull-request-checks
Sep 19, 2026
Merged

nimble-turtle merged 1 commit into
mainfrom
ci/pull-request-checks

Conversation

@nimble-turtle

@nimble-turtle nimble-turtle commented Sep 19, 2026 •

Copy link
Copy Markdown
Contributor

Problem

release.yml triggers only on push to main, so yarn test runs after a merge has already landed. Pull requests get no test CI at all — currently only CodeRabbit reports a status. A broken commit is caught once it is on main and mid-publish, which is how the failed run for chore: version packages (#8) surfaced.

Change

Adds .github/workflows/ci.yml, triggered on pull_request:

  • yarn typecheck
  • yarn test
  • yarn build

yarn build is included because prepack invokes it at publish time — a build break would otherwise stay invisible until the release run, after merge.

Notes:

  • permissions: contents: read — least privilege; this job needs nothing else.
  • concurrency is scoped per ref with cancel-in-progress, so a new push to a PR supersedes the run it obsoletes.
  • Trigger is pull_request only, not push: main. release.yml already runs the tests on main, so adding it here would duplicate every post-merge run.

Enabling branch protection

To make this a required check, the context name to select is Typecheck, test, build (the job's name:, not the job id verify).

No changeset

Intentionally omitted. This touches CI only and changes nothing in the published package, so it is not a releasable change under AGENTS.md. Adding one would trigger a version bump and an empty release.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Added automated continuous integration checks for pull requests.
    • CI now verifies type safety, tests, and production builds using a consistent environment.
    • In-progress checks are automatically canceled when newer changes are submitted.

release.yml only triggers on push to main, so yarn test ran after a merge
had already landed rather than before. A broken commit was caught only
once it was on main and mid-publish, which is how the failed run for
"chore: version packages" (#8) surfaced.

This adds a CI workflow on pull_request so the same checks gate the merge
instead of trailing it. It also runs yarn build, which prepack invokes at
publish time: a build break would otherwise stay invisible until the
release run.

Concurrency is scoped per ref with cancel-in-progress, so a new push to a
PR supersedes the run it obsoletes.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Sep 19, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: ae68aad6-366c-4054-bee7-59ba84259680

📥 Commits

Reviewing files that changed from the base of the PR and between 492b995 and 8786a68.

📒 Files selected for processing (1)
  • .github/workflows/ci.yml
 __________________________________________________________________________________________________
< Estimate to avoid surprises. Estimate before you start. You'll spot potential problems up front. >
 --------------------------------------------------------------------------------------------------
  \
   \   (\__/)
       (•ㅅ•)
       /   づ
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@nimble-turtle
nimble-turtle merged commit 568ecc3 into main Sep 19, 2026
1 of 2 checks passed
@nimble-turtle
nimble-turtle deleted the ci/pull-request-checks branch September 19, 2026 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant