New Folder button in sidebar not always working - #36
Open
MathPow wants to merge 1 commit into
Open
Conversation
✅ Deploy Preview for acreom-app ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I went to check the logic for when we add a folder, and it only works if there's an active tab open. It doesn't consider the MyDay page as an active tab. You needed to be inside a file.
Fix: Default to placing the folder at the root instead of doing nothing.
✨
Description by Callstackai
This PR modifies the logic for creating a new folder in the sidebar, ensuring that a folder can be created at the root level when there is no active folder.
Diagrams of code changes
sequenceDiagram participant User participant NewEntityDropdown participant EntitySystem User->>NewEntityDropdown: Clicks New Folder NewEntityDropdown->>EntitySystem: Get Active Folder EntitySystem-->>NewEntityDropdown: Returns Active Folder Note over NewEntityDropdown: Check if active folder<br/>is type FOLDER alt Active folder is type FOLDER NewEntityDropdown->>EntitySystem: Create new folder with:<br/>- Parent ID<br/>- Sharing UUID else Active folder is not type FOLDER NewEntityDropdown->>EntitySystem: Create new folder with:<br/>- No Parent ID<br/>- No Sharing UUID end EntitySystem-->>NewEntityDropdown: Returns new folder ID NewEntityDropdown->>NewEntityDropdown: Track folder creation eventFiles Changed
This PR includes files in programming languages that we currently do not support. We have not reviewed files with the extensions
.vue. See list of supported languages.