Skip to content

New Folder button in sidebar not always working - #36

Open
MathPow wants to merge 1 commit into
Acreom:mainfrom
MathPow:bugfix/i10-new-folder-not-working
Open

New Folder button in sidebar not always working#36
MathPow wants to merge 1 commit into
Acreom:mainfrom
MathPow:bugfix/i10-new-folder-not-working

Conversation

@MathPow

@MathPow MathPow commented Apr 21, 2025

Copy link
Copy Markdown

I went to check the logic for when we add a folder, and it only works if there's an active tab open. It doesn't consider the MyDay page as an active tab. You needed to be inside a file.

Fix: Default to placing the folder at the root instead of doing nothing.

electron_SLAYCZuOth

Description by Callstackai

This PR modifies the logic for creating a new folder in the sidebar, ensuring that a folder can be created at the root level when there is no active folder.

Diagrams of code changes
sequenceDiagram
    participant User
    participant NewEntityDropdown
    participant EntitySystem
    
    User->>NewEntityDropdown: Clicks New Folder
    NewEntityDropdown->>EntitySystem: Get Active Folder
    EntitySystem-->>NewEntityDropdown: Returns Active Folder
    
    Note over NewEntityDropdown: Check if active folder<br/>is type FOLDER
    
    alt Active folder is type FOLDER
        NewEntityDropdown->>EntitySystem: Create new folder with:<br/>- Parent ID<br/>- Sharing UUID
    else Active folder is not type FOLDER
        NewEntityDropdown->>EntitySystem: Create new folder with:<br/>- No Parent ID<br/>- No Sharing UUID
    end
    
    EntitySystem-->>NewEntityDropdown: Returns new folder ID
    NewEntityDropdown->>NewEntityDropdown: Track folder creation event
Loading
Files Changed
FileSummary
frontend/components/sidebar/SidebarTree/NewEntityDropdown.vueUpdated the new folder logic to allow creation at the root level when no active folder is present.

This PR includes files in programming languages that we currently do not support. We have not reviewed files with the extensions .vue. See list of supported languages.

@netlify

netlify Bot commented Apr 21, 2025

Copy link
Copy Markdown

Deploy Preview for acreom-app ready!

Name Link
🔨 Latest commit f8a8f76
🔍 Latest deploy log https://app.netlify.com/sites/acreom-app/deploys/68069c3a9805a5000813cfb5
😎 Deploy Preview https://deploy-preview-36.preview.acreom.com
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@MathPow

MathPow commented Apr 21, 2025

Copy link
Copy Markdown
Author

#10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant