refactor!: Rename some accesskit and accesskit_consumer types#734
refactor!: Rename some accesskit and accesskit_consumer types#734PoignardAzur wants to merge 5 commits into
Conversation
DataTriny
left a comment
There was a problem hiding this comment.
Please fix the intra doc links in the accesskit crate. We're clearly missing a CI check here.
accesskit::Tree is such a core type that I would prefer keeping it around for a few versions, but as a type alias:
#[deprecated]
pub type Tree = TreeInfo;Any opinion on replacing the type name by Self on impl blocks?
I haven't reviewed everything yet.
I think it could be a follow-up PR; mostly it would add even more noise. |
e2fb955 to
6877422
Compare
|
I've made the requested changes. I looked into splitting this PR into several smaller PRs, but I don't think it's practical (a lot of the renames affect overlapping lines). |
|
@PoignardAzur Some of the CI jobs fail because you need to rebase and rename more stuff in the adapters. |
|
I've fixed the Windows build failures, but I think the cargo-deny errors are unrelated to this PR? |
Rename accesskit::Tree to TreeInfo Rename accesskit_consumer::Node to accesskit_consumer::NodeRef Rename accesskit_consumer::NodeId to FullNodeId Rename accesskit_consumer::State to TreeState Because the previous names were ambiguous or had collisions, a lot of files imported them with aliases. This PR removes most of these alias imports. This is a rename-only PR with no behavior changes; most changes were done with rust-analyzer's "rename symbol" assist and similar (non-AI) tools.
0855ba5 to
a54bd68
Compare
|
How do you want to proceed for this? The file diff is pretty large (about 1200 lines changed) but it's exclusively symbol renames. |
|
Sorry @PoignardAzur for not communicating clearly here. I'm on board with these changes and they will be merged. I just can't afford the next release to be a minor version bump of all crates, so it will have to wait a bit. Can you please look into the two doc links you fixed in the accesskit crate? The mechanical rename make for weird sentences, we might be better off dropping these links alltogether. |
Closes #720
Rename accesskit::Tree to TreeInfo
Rename accesskit_consumer::Node to accesskit_consumer::NodeRef Rename accesskit_consumer::NodeId to FullNodeId
Rename accesskit_consumer::State to TreeState
Because the previous names were ambiguous or had collisions, a lot of files imported them with aliases.
This PR removes most of these alias imports.
This is a rename-only PR with no behavior changes; most changes were done with rust-analyzer's "rename symbol" assist and similar (non-AI) tools.