Fix for zsh-specific env loading behavior#2111
Open
derrickauyoung wants to merge 2 commits into
Open
Conversation
|
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2111 +/- ##
==========================================
- Coverage 60.65% 60.64% -0.02%
==========================================
Files 164 164
Lines 20584 20592 +8
Branches 3579 3579
==========================================
+ Hits 12485 12487 +2
- Misses 7224 7229 +5
- Partials 875 876 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Derrick Auyoung <derrick.auyoung@gmail.com>
7dcb6ba to
78e5a62
Compare
Signed-off-by: Derrick Auyoung <derrick.auyoung@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original Issue
Fixed #2058
Root Cause
zsh runs .zshenv before .zshrc, so the export HOME=/real/home inside the generated .zshenv triggered before rez's .zshrc could be sourced, bypassing the context
Fix
ZDOTDIRis the correct zsh-native mechanism for redirecting dot file loading, and doesn't require touching HOME at allshells.pyUnixShell class to implement default HOME environment var setting for the HOME env var hijackrezplugins/shells/zsh.pyclass to re-implement default methods to utilize ZDOTDIR insteadThanks to @JeanChristopheMorinPerso and @ legomir for their initial diagnosis and background info on this problem.