Repository navigation
Conversation
Signed-off-by: James Spadafora <spadjv@gmail.com>
…focus or press esc, we jump to the currently in review version. Signed-off-by: James Spadafora <spadjv@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change allows external apps to have better integration into DNA and update the in-review version. The external app sends a http request to upsert the in-review version on the playlist. This triggers an event that is picked up by the frontend.
If the user has the notebox selected, it will not change the inreview version unless the notes box losses focus. Users can hit esc to remove focus.
User stories:
I want to control the in-review version via an external app such as RV.
I want to see what is in review.
I want to auto follow the in-review version if it is changed elseware.
Testing
How I Tested
With the full stack running, I was able to change the inreview version by sending a curl command to the DNA backend. This in turn sent the update to the UI.