Repository navigation
Conversation
* Move shared render state, free-function renderer services, and the CUDA renderer library into a common source directory. * Give each example explicit source and include paths for host bitcode, NVCC PTX, and embedded CUDA bitcode while preserving the generated symbols and PTX filenames. * Use source-root include paths to remove parent-directory includes from these examples. * Keep testshade's camera ray flag independent of testrender's Ray definition. Assisted-by: OpenAI Codex / GPT-6 Signed-off-by: Tim Grant <tgrant@nvidia.com>
fpsunflower
approved these changes
Oct 21, 2026
fpsunflower
left a comment
fpsunflower
left a comment
Contributor
There was a problem hiding this comment.
LGTM
Instead of example_common, maybe it should be test_common (or testcommon) ?
testshade and testrender are both examples, but also used for unit testing.
Not a strong feeling, just throwing it out there for discussion.
Contributor
Author
|
I definitely waffled on the name a bit. I'm happy to change it to something that communicates the intent of the projects more clearly. |
testshade and testrender are used by the testsuite as well as serving as examples. Rename their shared source directory accordingly and update the CMake and include paths. The compiled code is unchanged. Assisted-by: OpenAI Codex / GPT-6 Signed-off-by: Tim Grant <tgrant@nvidia.com>
Collaborator
|
Does this fully solve #2183? If so, before merging, we should edit the description to use the magic words Or "fixes". Either one will actually cause the issue to close when this merges. But just mentioning the issue in other ways doesn't do so. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change fixes #2183 (and, with a little luck, also closes #2183).
There is some unfortunate sharing of the CUDA sources between testshade and testrender that requires each project to reach into the other's source directory, which clouds the boundary between projects.
The solution we are proposing is to move the shared sources to a common directory.
Tests
No new tests added, nor any change in test results before and after the patch.
Checklist:
and if I used AI coding assistants, I have an
Assisted-by: TOOL / MODELline in the pull request description above.
behavior.
PR, by pushing the changes to my fork and seeing that the automated CI
passed there. (Exceptions: If most tests pass and you can't figure out why
the remaining ones fail, it's ok to submit the PR and ask for help. Or if
any failures seem entirely unrelated to your change; sometimes things break
on the GitHub runners.)
fixed any problems reported by the clang-format CI test.
Assisted-by: OpenAI Codex / GPT-6