Repository navigation
testing: runtest.py improvements ported from OpenImageIO - #2189
Merged
Merged
Conversation
Port the parts of OIIO PR 5465 and 5476 that apply to OSL's runtest.py: * run_app() takes a failureok parameter. If the first word of the command names an OSL app (oslc, oslinfo, testshade, testrender, testoptix) or an OIIO app (oiiotool, maketx, etc.), it is replaced with the full path to the built app. * New run_commands() takes a multi-line string of shell commands, one per line, and runs each through run_app(). Blank lines and `#` comments are skipped. So a run.py can list commands exactly as they would be typed, and docs can include them by reference. * The oslc, oslinfo, oiiotool, maketx, oiiodiff, testshade, testrender, and testoptix helpers are now thin wrappers around run_app(). oiiotool() also gained failureok and concat parameters. * text_diff ignores trailing whitespace differences, which can vary by platform (e.g. cmd.exe's echo). * redirect_push and redirect_pop to let a test redirect a portion of output to a different file. Assisted-by: Claude Code / Claude Opus 5.5 Signed-off-by: Larry Gritz <lg@larrygritz.com>
Collaborator
Author
|
No objections, port of code that's worked for a long time in OIIO -> merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port the parts of OIIO PR 5465 and 5476 that apply to OSL's runtest.py:
#comments are skipped. So a run.py can list commands exactly as they would be typed, and docs can include them by reference.Assisted-by: Claude Code / Claude Opus 5.5