fix: read item-wise tax breakup from _item_wise_tax_details on v16 - #446
Open
av-dev2 wants to merge 205 commits into
Open
fix: read item-wise tax breakup from _item_wise_tax_details on v16#446av-dev2 wants to merge 205 commits into
av-dev2 wants to merge 205 commits into
Conversation
Anchor the exclude regex so it stops swallowing .github, add the pre-push full-repository-check stage, scope ruff hooks to csf_tz, and add the no-commit-to-branch guard per the pre-commit-enforcement skill.
Bootstrap developer hook installs with one command and gate pull requests with a full-repository pre-commit run, per the pre-commit-enforcement skill's required file set.
pip install -e .[dev] should pull in pre-commit so the bootstrap script has something to install if uv/pipx are unavailable.
Both release.yml and tag-and-promote-from-pr-label.yml owned tagging and releasing at once; semantic-release would tag a release commit that tag-and-promote never sees, failing that job.
fix: adapt csf_tz to Frappe 16, ERPNext 16 and HRMS 16 APIs
fix: correct defects found while testing on version-16- Aakvatech-Limited#439
fix: repair the desk client scripts and pages for version-16- Aakvatech-Limited#440
fix: repair the csf_tz reports on version-16
chore: apply the Frappe version-16 migration guide items
test: add an integration test suite for version-16- Aakvatech-Limited#443
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
item_wise_tax_detailJSON field fromSales Taxes and Chargesrows in favour ofdoc._item_wise_tax_details, which crashedvfd_validationon Sales Invoice submit withAttributeError: 'SalesTaxesandCharges' object has no attribute 'item_wise_tax_detail'.get_itemised_tax_breakup_data/get_itemised_taxnow read the newdoc._item_wise_tax_detailsrows (populated duringcalculate_taxes_and_totals, beforebefore_submitruns), keeping the same{item_code: {tax_description: {tax_rate, tax_amount}}}return shapevfd_validationrelies on..pre-commit-config.yaml,pyproject.toml, and the missing pre-commit workflow/bootstrap script up to the pre-commit-enforcement baseline (anchored excludes, three hook stages,no-commit-to-branch, dropped the duplicatesemantic-releaseworkflow). Left the rest of a full-repo audit alone since other open PRs against this branch already cover it.Test plan
AttributeErrorvfd_validation's standard/non-standard tax-code checks still throw correctly for misconfigured item tax templates