chore: apply the Frappe version-16 migration guide items - #442
Open
av-dev2 wants to merge 41 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applies the items from frappe's Migrating to version 16 guide that csf_tz still owed. Each commit covers one file.
Changes
creation descinstead ofmodified descand no longer indexesmodified. All 39 non-child DocTypes that still declaredsort_field: "modified"now sort bycreation, matching frappe core (98 of its 101 core DocTypes). Child tables are untouched — they ignoresort_field.add_to_apps_screen, so csf_tz never appeared. Added with the app logo and the/desk/tanzaniaroute;frappe.apps.get_apps()now returns it beside ERPNext and Frappe HR.appfield used by the new sidebar and desktop; the Tanzania workspace had none.The remaining guide items were audited and needed no change here: the removed translation APIs,
value_cache, GeoIP,site_cache,bleach, Transaction Log, the POST-only endpoints andsendmail(now=True)are not used;has_permissionhooks are not registered; Time field defaults already use"Now"; andget_valid_columns()is only called on DocTypes without virtual fields. The guide's other applicable items are covered by the compatibility, client-script and reports pull requests.Note on review order
The
sort_fieldchange is the one with visible user impact: list views default to newest-created rather than most-recently-modified. It is the guide's recommended migration, and it is isolated in this pull request so it can be accepted or deferred on its own.Verification
bench migrateis clean and the full suite (631 test cases) passes with these changes applied.