fix: repair the desk client scripts and pages for version-16 - #440
Open
av-dev2 wants to merge 13 commits into
Open
fix: repair the desk client scripts and pages for version-16#440av-dev2 wants to merge 13 commits into
av-dev2 wants to merge 13 commits into
Conversation
av-dev2
added a commit
to av-dev2/csf_tz
that referenced
this pull request
Aug 30, 2026
fix: repair the desk client scripts and pages for version-16- Aakvatech-Limited#440
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repairs the Desk client scripts and custom pages on version-16. Found by opening every csf_tz form and page in a real browser (Playwright + Chrome) as Administrator. Each commit covers one file.
Fixed
doctype_jshook and its client script pointed at a DocType that no longer exists, and the script called a method that is not whitelisted. Both removed.csf_tz.custom_api.get_warehouse_optionswas called withoutcompany. The script now waits until a company is set.settings.limit_uom_as_item_uomhitundefined.additional_costschild table that this app does not install.<head>included, injected into a Desk page, so the browser reportedUnexpected token '<'. It is now a fragment, and the scanner library is loaded explicitly with a readable message when it cannot be reached.Order ProgressandOrder Tracking Item, DocTypes that no app defines. They broke the form and stopped the v16 test runner from resolving links. The client script also called amake_product_inspectionmethod that does not exist./app/...; v16 reroutes/appto/desk.Verification
Every affected form and page was reloaded in the browser afterwards and renders with no console or page error.
test_client_script_refs(companion tests branch) now asserts that every server method named in a csf_tz client script exists and is whitelisted.