fix: correct defects found while testing on version-16 - #439
Open
av-dev2 wants to merge 13 commits into
Open
Conversation
av-dev2
added a commit
to av-dev2/csf_tz
that referenced
this pull request
Aug 30, 2026
fix: correct defects found while testing on version-16- Aakvatech-Limited#439
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Defects found while building the version-16 test suite. These are logic errors rather than framework drift, so they are separated from the compatibility work. Each commit covers one file.
Fixed
custom_apireadStock Ledger Entry.batch_no, which v16 no longer writes now that batches go through bundles. It now reads batch quantities through the stock helpers.get_item_prices,get_item_prices_custom,get_item_prices_po,get_item_prices_custom_po,get_pending_sales_invoice,get_item_info). They now callfrappe.has_permission(..., throw=True). The employee contact QR endpoint had the same gap.create_delivery_note_for_all_pending_sales_invoiceraised on every daily run — afiters=typo in the scheduled job.doc.posting_date; a Purchase Order has no such field, so enabling the check raisedAttributeError.queue.claim_batchreferenced an undefinedWORKER_ID, so every claim failed and was swallowed by the surroundingexcept.attached_to_field.employee.bank_country_codeandemployee_country_code, columns that do not exist.create_the_stock_entry_typeraisedDuplicateEntryErrorwhen re-run, and the Selcom client referenced an unboundresponseon failure.Verification
Each fix has a test in the companion tests branch; the full suite is 631 passing test cases on Frappe 16 / ERPNext 16 / HRMS 16.