fix: restore weighbridge_ticket item link fields dropped by #136 - #137
Merged
av-dev2 merged 1 commit intoAug 31, 2026
Conversation
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin version-15
git worktree add -d .worktree/backport-137-to-version-15 origin/version-15
cd .worktree/backport-137-to-version-15
git switch --create backport-137-to-version-15
git cherry-pick -x cb3192d4bb1f5aee54db2655e17a21500af08cc6 |
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin version-16-hotfix
git worktree add -d .worktree/backport-137-to-version-16-hotfix origin/version-16-hotfix
cd .worktree/backport-137-to-version-16-hotfix
git switch --create backport-137-to-version-16-hotfix
git cherry-pick -x cb3192d4bb1f5aee54db2655e17a21500af08cc6 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
av_tools.weigh_bridge.custom_fields.setup_custom_fieldswith a JSON fixture but was built against a stale local copy of that file, so it only carried over theVehicle.default_tare_weightfield and silently dropped theweighbridge_ticketLink field on six Item child doctypes (Sales Invoice Item,Delivery Note Item,Sales Order Item,Purchase Order Item,Purchase Invoice Item,Purchase Receipt Item).weigh_bridge/api.pywritesrow.weighbridge_ticket/child.weighbridge_ticketwhen building invoices/orders from a weighbridge ticket — so any new install or resync would no longer create it.git cherry-pickhit amodify/deleteconflict onweigh_bridge/custom_fields.pybecauseversion-15/version-16-hotfixcarry different content for that file than what fix: sync authotp and weighbridge custom fields via json fixtures #136's deletion commit expected.weigh_bridge_custom_fields.json, alongside theVehiclefield, so the existing genericcreate_custom_fields.executeloader recreates them.Test plan
av_tools.utils.create_custom_fields.executeagainst an existing site (amex-local); confirmed all sixweighbridge_ticketItem fields plusVehicle.default_tare_weightare created/synced correctly and tagged with theAv Toolsmodule.pre-commit run --all-filespasses.