chore: name the rule and reason on the hooks.py semgrep waiver - #133
Merged
aakvatech merged 1 commit intoAug 28, 2026
Conversation
The waiver was a bare # nosemgrep, which silences every rule on that line and records no reason. Now names override-doctype-class and says why, matching the other waivers in this app.
aakvatech
merged commit Aug 28, 2026
3c224ff
into
Aakvatech-Limited:version-16-hotfix
4 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #132, which merged before this commit landed.
av_tools/hooks.pycarried a bare trailing# nosemgrep:A bare waiver silences every rule on that line, not just the one that was
reviewed, and records no reason. A rule that starts firing there later is
suppressed silently.
It now names the rule and says why, matching the other waivers in this app and
the form already on
version-15-hotfix:No behaviour change.
pre-commit run --all-filespasses.