Skip to content

Avoid dereferencing encrypted_record when null #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nrosner wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Avoid dereferencing encrypted_record when null #54

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 13 additions & 11 deletions ...tion-java-master/examples/src/main/java/com/amazonaws/examples/AwsKmsEncryptedObject.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,17 +109,19 @@ public static void encryptRecord(
final Map<String, AttributeValue> encrypted_record =
ddbClient.getItem(EXAMPLE_TABLE_NAME, itemKey).getItem();
System.out.println("Encrypted Record: " + encrypted_record);

// Encrypted record fields change as expected
assert encrypted_record.get(STRING_FIELD_NAME).getB()
!= null; // the encrypted string is stored as bytes
assert encrypted_record.get(NUMBER_FIELD_NAME).getB()
!= null; // the encrypted number is stored as bytes
assert !ByteBuffer.wrap(record.getSomeBinary())
.equals(encrypted_record.get(BINARY_FIELD_NAME).getB()); // the encrypted bytes have updated
assert record
.getLeaveMe()
.equals(encrypted_record.get(IGNORED_FIELD_NAME).getS()); // ignored field is left as is

if(encrypted_record != null) {
// Encrypted record fields change as expected
assert encrypted_record.get(STRING_FIELD_NAME).getB()
!= null; // the encrypted string is stored as bytes
assert encrypted_record.get(NUMBER_FIELD_NAME).getB()
!= null; // the encrypted number is stored as bytes
assert !ByteBuffer.wrap(record.getSomeBinary())
.equals(encrypted_record.get(BINARY_FIELD_NAME).getB()); // the encrypted bytes have updated
assert record
.getLeaveMe()
.equals(encrypted_record.get(IGNORED_FIELD_NAME).getS()); // ignored field is left as is
}

// Retrieve (and decrypt) it from DynamoDB
DataPoJo decrypted_record = mapper.load(DataPoJo.class, "is this", 55);
Expand Down