Skip to content

Busted 2 bugs #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bryblant-amazon wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Busted 2 bugs #38

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
12878a8
Added timeout to CompletableFuture.get()
bryblant-amazon Nov 8, 2021
9a88bd5
Added try-with-resources block around dialog
bryblant-amazon Nov 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion aws-iot-device-sdk-java-v2-main/samples/BasicPubSub/src/main/java/pubsub/PubSub.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
import java.util.concurrent.CompletableFuture;
import java.util.concurrent.CountDownLatch;
import java.util.concurrent.ExecutionException;
import java.util.concurrent.TimeUnit;

public class PubSub {

Expand Down Expand Up @@ -332,7 +333,7 @@ public void onConnectionResumed(boolean sessionPresent) {
int count = 0;
while (count++ < messagesToPublish) {
CompletableFuture<Integer> published = connection.publish(new MqttMessage(topic, message.getBytes(), QualityOfService.AT_LEAST_ONCE, false));
published.get();
published.get(10, TimeUnit.SECONDS);
Thread.sleep(1000);
}

Expand Down
7 changes: 4 additions & 3 deletions ...onaws.eclipse.dynamodb/src/com/amazonaws/eclipse/explorer/dynamodb/DynamoDBTableNode.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,16 +122,17 @@ public void run() {
@Override
public void run() {
/* Show the warning that the table is CREATING/DELETING/UPDATING */
MessageDialog dialog = new MessageDialog(
try (MessageDialog dialog = new MessageDialog(
Display.getCurrent().getActiveShell(),
"Cannot open this table",
AwsToolkitCore.getDefault()
.getImageRegistry()
.get(AwsToolkitCore.IMAGE_AWS_ICON),
"Cannot open this table(" + tableName + "), since it is in the status of " + tableStatus + ".",
MessageDialog.ERROR,
new String[] { "OK" }, 0);
dialog.open();
new String[] { "OK" }, 0)) {
dialog.open();
}
}
});
}
Expand Down