Webspark 2.19.0 hotfix - fix webdir nav controls - PROXY API - #1759
Merged
Conversation
…eact-dom/server - Restore the .scroll-control-prev/-next and carousel-control-*-icon styles into NavControls.styles.js (co-located with the component instead of unity-bootstrap-theme). PR #1698's TabbedPanels redesign removed this CSS assuming it was dead code from the old carousel-based tabs, but NavControls is still used standalone by app-webdir-ui's Filter component ("Filter by Last Initial"), which regressed to unstyled buttons as a result. - Split getBootstrapHTML (react-dom/server, Storybook/dev-tooling only) out of useBaseSpecificFramework.js into its own file. Every component imports useBaseSpecificFramework at runtime, so bundling react-dom/server there was pulling server-rendering internals (MessageChannel, TextEncoder, etc.) into every consumer's published dist for no runtime benefit, and broke jsdom-based tests in app-webdir-ui.
…-react-core dependency ranges Both were pinned to ^1.x ranges that no longer match the workspace's current major versions (unity-bootstrap-theme 2.x, unity-react-core 2.x), causing yarn to resolve a stale published copy from the registry instead of symlinking the local workspace package.
… range Was pinned to ^1.0.0, which no longer matches the workspace's current 2.x version, causing yarn to resolve a stale published copy from the registry instead of symlinking the local workspace package.
…ange Was pinned to ^1.0.0, which no longer matches the workspace's current 2.x version, causing yarn to resolve a stale published copy from the registry instead of symlinking the local workspace package.
… range Was pinned to ^1.20, which no longer matches the workspace's current 2.x version, causing yarn to resolve a stale published copy from the registry instead of symlinking the local workspace package.
… range Was pinned to ^1.0.0, which no longer matches the workspace's current 2.x version, causing yarn to resolve a stale published copy from the registry instead of symlinking the local workspace package.
scott-williams-az
changed the title
Collaborator
|
Storybook deployed at https://unity-uds-staging.s3.us-west-2.amazonaws.com/pr-1759/index.html |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the nav controls styling issue by reintroducing the styles into their own styled components files for unity-react-core and issues a new verison for app-webdir-ui and unity-react-core. Tests were also added for app0-webdir-ui as there was a fix added for anon images not showing up.
Mock api data was also added for app-webdir-ui as the search endpoints no longer allow certain domains to query them.
Also:
out of useBaseSpecificFramework.js into its own file. Every component
imports useBaseSpecificFramework at runtime, so bundling
react-dom/server there was pulling server-rendering internals
(MessageChannel, TextEncoder, etc.) into every consumer's published
dist for no runtime benefit, and broke jsdom-based tests in
app-webdir-ui.
Description
Checklist
Important Reminders
Links
Using a local proxy server, we can use real data